[NAntC-Dev] [ nantcontrib-Bugs-1587993 ] bad stylesheet link in nunit2report

[SourceForge.net <no...@so...>]

Bugs item #1587993, was opened at 2006-10-31 17:08
Message generated for change (Comment added) made by drieseng
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=474851&aid=1587993&group_id=54790

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Tasks
Group: 0.85
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Paul (paulc1)
Assigned to: Nobody/Anonymous (nobody)
Summary: bad stylesheet link in nunit2report

Initial Comment:
The link to the stylesheet in the pages for the 
individual fixtures is wrong.  It contains far too 
many '../'.  (For example on a class with 5 parts to 
the fully qualified name (i.e. x.x.x.x.x) the link is

'../../../../../../../../../../../../../../../styleshe
et.css'

I think this is down to the logic in the 
<xsl:template name="path"> template.

I think it should be like so

<xsl:template name="path">
    <xsl:param name="path"/>
    <xsl:choose>
        <xsl:when test="contains($path,'.')">
            <xsl:text>../</xsl:text>    
            <xsl:call-template name="path">
                <xsl:with-param 
name="path"><xsl:value-of select="substring-after
($path,'.')"/></xsl:with-param>
            </xsl:call-template>    
        </xsl:when>
        <xsl:otherwise>
            <xsl:if test="not(contains($path,'.')) 
and not($path = '')">
                <xsl:text>../</xsl:text>    
            </xsl:if>
        </xsl:otherwise>
    </xsl:choose>
</xsl:template>

The current implementation is 

<xsl:template name="path">
    <xsl:param name="path"/>
       <xsl:if test="contains($path,'.')">
            <xsl:text>../</xsl:text>    
            <xsl:call-template name="path">
                <xsl:with-param 
name="path"><xsl:value-of select="substring-after
($path,'.')"/></xsl:with-param>
            </xsl:call-template>    
        </xsl:if>
        <xsl:if test="not(contains($path,'.')) and not
($path = '')">
           <xsl:text>../</xsl:text>    
        </xsl:if>
</xsl:template>

for which the lower if condition will be entered 
after the recursive call unecessarily, which results 
in the extra '../' being added.




----------------------------------------------------------------------

>Comment By: Gert Driesen (drieseng)
Date: 2006-10-31 17:21

Message:
Logged In: YES 
user_id=707851

Please provide a small repro for this issue.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=474851&aid=1587993&group_id=54790