[nail-devel] nail core dumps on smime signing / folder removal (fix included)
Brought to you by:
gritter
From: Martin N. <ne...@ga...> - 2007-03-08 16:05:32
|
nail has a small "y/n" questionaire utility which will segfault when the user just hits return. Repeat-by: Either "set asksign", compose a msg, just hit return or "remove /etc/motd", just hit return These are all places which call yorn() and can therfore trigger the bug. The patch below will guard against this. Martin Index: tty.c =================================================================== RCS file: /cvsroot/nail/nail/tty.c,v retrieving revision 1.10 diff -u -r1.10 tty.c --- tty.c 4 Mar 2006 00:32:16 -0000 1.10 +++ tty.c 8 Mar 2007 16:01:39 -0000 @@ -430,6 +430,6 @@ return 1; do cp = readtty(msg, NULL); - while (*cp != 'y' && *cp != 'Y' && *cp != 'n' && *cp != 'N'); + while (!cp || *cp != 'y' && *cp != 'Y' && *cp != 'n' && *cp != 'N'); return *cp == 'y' || *cp == 'Y'; } |