[Nagios-checkins] SF.net SVN: nagios:[2282] nagioscore/trunk/base/query-handler.c

[<ag...@us...>]

Revision: 2282
          http://nagios.svn.sourceforge.net/nagios/?rev=2282&view=rev
Author:   ageric
Date:     2012-09-21 13:14:29 +0000 (Fri, 21 Sep 2012)
Log Message:
-----------
query-handler: Plug a leak in the error path

If we fail to register the socket with the iobroker, we must destroy
the iocache we previously used to handle input.

Signed-off-by: Andreas Ericsson <ae...@op...>

Modified Paths:
--------------
    nagioscore/trunk/base/query-handler.c

Modified: nagioscore/trunk/base/query-handler.c
===================================================================
--- nagioscore/trunk/base/query-handler.c	2012-09-21 10:34:02 UTC (rev 2281)
+++ nagioscore/trunk/base/query-handler.c	2012-09-21 13:14:29 UTC (rev 2282)
@@ -62,6 +62,7 @@
 		 */
 		if(iobroker_register(nagios_iobs, nsd, ioc, qh_input) < 0) {
 			logit(NSLOG_RUNTIME_ERROR, TRUE, "Error: Failed to register query input socket %d with I/O broker: %s\n", nsd, strerror(errno));
+			iocache_destroy(ioc);
 			close(nsd);
 			return 0;
 		}

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.