From: <ag...@us...> - 2012-07-09 00:53:00
|
Revision: 2014 http://nagios.svn.sourceforge.net/nagios/?rev=2014&view=rev Author: ageric Date: 2012-07-09 00:52:54 +0000 (Mon, 09 Jul 2012) Log Message: ----------- core: Zero-initialize low-priority timed events Without doing this, we might get random usec values in the sq_event, which is quite bad since we're using it to determine runtime in the scheduling queue, which in turns decides the amount of time we spend polling. Signed-off-by: Andreas Ericsson <ae...@op...> Modified Paths: -------------- nagioscore/trunk/base/checks.c Modified: nagioscore/trunk/base/checks.c =================================================================== --- nagioscore/trunk/base/checks.c 2012-07-09 00:52:33 UTC (rev 2013) +++ nagioscore/trunk/base/checks.c 2012-07-09 00:52:54 UTC (rev 2014) @@ -1723,7 +1723,7 @@ if(use_original_event == FALSE) { /* allocate memory for a new event item */ - new_event = (timed_event *)malloc(sizeof(timed_event)); + new_event = (timed_event *)calloc(1, sizeof(timed_event)); if(new_event == NULL) { logit(NSLOG_RUNTIME_WARNING, TRUE, "Warning: Could not reschedule check of service '%s' on host '%s'!\n", svc->description, svc->host_name); return; @@ -2215,7 +2215,7 @@ log_debug_info(DEBUGL_CHECKS, 2, "Scheduling new host check event.\n"); /* allocate memory for a new event item */ - if((new_event = (timed_event *)malloc(sizeof(timed_event))) == NULL) { + if((new_event = (timed_event *)calloc(1, sizeof(timed_event))) == NULL) { logit(NSLOG_RUNTIME_WARNING, TRUE, "Warning: Could not reschedule check of host '%s'!\n", hst->name); return; } This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |