Re: [Mvpmc-devel] libcmyth and xbmc
Status: Alpha
Brought to you by:
gettler
From: Charles B. <cgb...@gm...> - 2010-12-14 09:08:20
|
Thanks all for your input. Even I should have realised 23056 % 100 would give you 56 - senior moment. The use of 23056 is as far as I can see is an unusual situation. It was caused by a conflict between the development branch and the production branch. I think the people working on 0.23 wanted to make protocol changes, but the 0.24 development branch had claimed 57 as a version, and the 0.23 developers could not use 58 without including all of the changes made in 57, so they chose to use 23056. I think this is unlikely to happen again. I also agree with Tom's comments that generalising the code to just use the last two digits is dangerous because at some point in the future we might need to do something differently for 56 and 23056. So at the moment my plan is to leave the conditional statements in, with some comments about 0.23.1. Charles Barnwell |