[Mvpmc-devel] Mythtv commercial skipping

[Chris R. <cr...@in...>]

Firstly, thanks all for the work you've done on mvpmc.

I've tried using the commercial skipping feature of the mythtv client in 
mvpmc, but found that it did not query the commercial skip list correctly.

Thing is, I don't understand how the existing code works at all, as the 
join query it executes compares FLOOR(m.mark/15) with s.mark - so will 
find offsets that are a factor of 15 out.  I also found that in my 
database, the recordedseek positions were anywhere between 10 and 50 
frames apart (possibly more?), so the division by 15 was not sufficient 
for some frame indices to match, and some would result in multiple 
matches, which would result in the code populating commbreak_list to 
reject the query.

Attached is a patch that fixes both of these problems, and makes 
commercial skipping work (for me), and more forgiving about what comes 
out of the database.

This is all with MythTV 0.21 and mvpmc-0.3.4 (though patch is against 
latest in git repository), recording from a DVB-T card.

Like I said, I don't understand how it could have ever worked, so maybe 
I'm confused about something.  If someone could explain how the old code 
was supposed to work, then that may help.

Thanks.