From: Jimmy O. <jo...@li...> - 2004-04-28 16:06:08
|
(First, "Hi everybody!". I'm back again. :-) Once upon a time, Lupe Christoph <lu...@lu...> sagely scribed: > On Thursday, 2004-04-22 at 20:01:43 +0200, Jacques Caruso wrote: >=20 > > Should these be fixed=A0? And what should they do=A0? Print an error=A0= or exit=20 > > silently=A0? >=20 > Personally, I try to always print an error message when I detect an > error condition. Makes it easier to track doen the cause ... I agree. It should print an error to stderr, and exit with a state other than 0. Any stderr-output will be visible in munin-node.log. =20 > The good thing about the "use" statement is that perl aborts the program > when it fails.=20 The bad thing about the "use" statement is that "autoconf" fails too ungracefully. > But I don't want a large number of plugins to change that are not really > broken just before the first release. Let's break them after release ;-) Humm...I guess I just wrote this mail pretty much to say that I agree with Lupe on everything he's said in it. :-P =2E..almost. :-) One other thing -- a file "README.plugins" is found in the plugin directory of all node installations, as well as the "node/node.d/ in CVS. This file has the requirements for plugins that are officially supported (auto and manual families, not contrib). After the 1.0 release, this document should be revamped to include requirements such as these. That way, people won't have to wonder in what cases requirements should be checked, how to fail, etc. :-) After 1.0 is released, I'll do some preliminary modifications to the document, then post it here so everybody can have their say about how the supported plugins should behave. -jo :) |