[MRBS-general] All day booking

[Larvoire, Jean-F. <jea...@hp...>]

Hello,

There's a problem with the "All day" checkbox in the reservation form.

Its function is not clearly defined in the doc, nor in the help files.
I assumed it meant booking for the whole 24 hours of a day.
And I didn't like the lack of feedback when the checkbox was checked.
So I added javascript in mrbs 1.2 in edit_entry.php to change the start =
time to 00h00, and duration to 1 day, in the form, when the user clicks =
on "All day".
The feedback looked fine, and I was happy...

The problem is that "all day" does not work this way!
edit_entry_handler.php ignores the contents of the start time and =
duration fields when "all day" is checked.
It blindly sets the start time and end time to $morningstarts and =
$eveningends from config.inc.php.

So the visual feedback I put is mrbs 1.2 is wrong and misleading.

A feedback consistant with "all day" implementation would then be to =
disable (grey-out if possible) the fields that will be ignored, and set =
them to $morningstarts and $eveningends values.

This makes sense when configured in period mode, where booking outside =
of defined periods is meaningless.

But in clock mode, bookings can span the whole 24 hours, even if only a =
subset is displayed.
And booking for several "whole days" is a common need for us.
Finally I don't want to set $morningstarts and $eveningends to 0h00 and =
23h, to keep the calendar reasonably small.

Before making any change, I'd like your opinion:
Are you using the "all day" option?
Whether you use it or not, how would you like "all day" booking to work?

Jean-Fran=E7ois

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
=3D Jean-Fran=E7ois Larvoire                 =3D=3D=3D=3D=3D=3D=3D=3D=3D =
  _/      =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
=3D Hewlett-Packard                        =3D=3D=3D=3D=3D=3D=3D    _/   =
        =3D=3D=3D=3D=3D=3D=3D
=3D 5 Avenue Raymond Chanas, Eybens        =3D=3D=3D=3D=3D     _/_/_/  =
_/_/_/  =3D=3D=3D=3D=3D
=3D 38053 Grenoble Cedex 9, FRANCE         =3D=3D=3D=3D=3D    _/  _/  _/ =
 _/   =3D=3D=3D=3D=3D
=3D Phone: +33 476 14 13 38                =3D=3D=3D=3D=3D   _/  _/  =
_/_/_/    =3D=3D=3D=3D=3D
=3D Fax:   +33 476 14 45 19                =3D=3D=3D=3D=3D=3D=3D        =
_/       =3D=3D=3D=3D=3D=3D=3D
=3D Email: jea...@hp...   =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D    _/     =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D