Re: [MRBS-general] Meetings moved when summertime started
Brought to you by:
jberanek
From: Gavin W. <ga...@th...> - 2004-03-29 20:31:04
|
This is a known bug and was fixed in the 1.2-pre2 release. However, I am still surprised that the meeting moved out 2 hours. Anyway for your info I have pasted the commit notes for the fix below. I would suggest that you consider upgrading if possible. Regards Gavin -------------- Daylight Saving Time fixes. This has involved modifying month.php, week.php and day.php, view_entry.php, edit_entry.php, edit_entry_handler.php, mbs_sql.inc and functions.inc For month.php and week.php, I have changed them to handle each week/month on a day by day basis. They and day.php make DST corrections for the start and end of each day. The intervals of time are handled by using the format HHMM with no leading zeros. Events are read in to an array using this format of time as the one of the indices. A day which does not include a DST change is used to loop through all valid hours for that day. The view_entry.php has been altered to modify times that cross DST back to what the user would expect 9pm to 3am is 6 hours but it is stored as either 5 or 7 hours. The edit_entry.php, edit_entry_handler.php and mrbs_sql.inc have been changed to correctly calculate the difference between two timestamps and correct the end time for checking the following: free time, all day events and repeating events. functions.inc includes two new functions: one to check for DST and one to correct for DST. These are used in the fixes above. Where possible, calculations that used to use midnight have been changed to use midday to avoid DST problems. You may still see some "strange" but correct behaviour when scheduling meetings which start and/or end between midnight and 3 am on a day of DST. These may look wrong but should actually be correct if you consider how DST works on that day, i.e in the UK the hour from 1am to 2pm does not exist when entering DST. Backward compatibility: There may be a one hour error for events that start or end between midnight and 3am on the day that DST changes but these can be fixed by editing the entry/series and saving it. |