Re: [Mplayerplug-in-devel] mplayerplug-in 3.16 gtk1 build issue

[Kevin D. <kde...@ya...>]

On Wed, 2005-11-30 at 13:43 +0000, Roderick Johnstone wrote:
> Kevin DeKorte wrote:
> > On Wed, 2005-11-30 at 11:28 +0000, Roderick Johnstone wrote:
> >=20
> >>Hi
> >>
> >>After configuring mplayerplug-in 3.16 like:
> >>
> >>./configure --disable-rm -with-gecko-sdk=3D/scratch/rmj/packages/gecko-=
sdk=20
> >>  --enable-gtk1
> >>
> >>make gives the following error:
> >>
> >>g++ -c -o plugin-ui.o -Wall -g -O2  -I/usr/X11R6/include  -g -O2=20
> >>-DXP_UNIX -DMOZ_X11 -I/scratch/rmj/packages/gecko-sdk=20
> >>-I/scratch/rmj/packages/gecko-sdk/include -Iinclude -fPIC -DXPCOM_GLUE=20
> >>-DMOZILLA_STRICT_API -I/usr/include/gtk-1.2 -I/usr/X11R6/include=20
> >>-I/usr/include/glib-1.2 -I/usr/lib/glib/include   -D_REENTRANT=20
> >>-I/usr/include/glib-1.2 -I/usr/lib/glib/include   -DGTK_ENABLED=20
> >>Source/plugin-ui.cpp
> >>Source/plugin-ui.cpp: In function `gboolean=20
> >>gtkgui_drawMediaProgress(void*)':
> >>Source/plugin-ui.cpp:1548: error: `gtk_progress_bar_set_text' undeclare=
d=20
> >>(firstuse this function)
> >>Source/plugin-ui.cpp:1548: error: (Each undeclared identifier is=20
> >>reported only once for each function it appears in.)
> >>Source/plugin-ui.cpp:1550: warning: zero-length printf format string
> >>Source/plugin-ui.cpp:1550: warning: zero-length printf format string
> >>Source/../pixmaps/start.xpm: At global scope:
> >>Source/../pixmaps/start.xpm:2: warning: 'start' defined but not used
> >>make: *** [plugin-ui.o] Error 1
> >>
> >>I tried with gecko-sdk 1.6 and 1.7.
> >>
> >>Any ideas what I do to fix this?
> >>
> >>Thanks
> >>
> >>Roderick Johnstone
> >=20
> >=20
> > Comment out line 1548 in plugin-ui.cpp and recompile...
>=20
> ok so line 1548 is just:
>=20
>                        display);
>=20
> so I commented out 1547 and 1548. Hope thats right, but then I get:
>=20
> g++ -c -o plugin-ui.o -Wall -g -O2  -I/usr/X11R6/include  -g -O2=20
> -DXP_UNIX -DMOZ_X11 -I/scratch/rmj/packages/gecko-sdk=20
> -I/scratch/rmj/packages/gecko-sdk/include -Iinclude -fPIC -DXPCOM_GLUE=20
> -DMOZILLA_STRICT_API -I/usr/include/gtk-1.2 -I/usr/X11R6/include=20
> -I/usr/include/glib-1.2 -I/usr/lib/glib/include   -D_REENTRANT=20
> -I/usr/include/glib-1.2 -I/usr/lib/glib/include   -DGTK_ENABLED=20
> Source/plugin-ui.cpp
> Source/plugin-ui.cpp: In function `gboolean=20
> gtkgui_drawMediaProgress(void*)':
> Source/plugin-ui.cpp:1550: warning: zero-length printf format string
> Source/plugin-ui.cpp:1550: warning: zero-length printf format string
> Source/plugin-ui.cpp:1552: error: `gtk_progress_bar_set_text' undeclared=20
> (firstuse this function)
> Source/plugin-ui.cpp:1552: error: (Each undeclared identifier is=20
> reported only once for each function it appears in.)
> Source/../pixmaps/start.xpm: At global scope:
> Source/../pixmaps/start.xpm:2: warning: 'start' defined but not used
> make: *** [plugin-ui.o] Error 1
>=20
> Roderick

Do the same to line 1552 or grab CVS in an hour or so as it compiles.

Or apply this patch

Index: plugin-ui.cpp
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvsroot/mplayerplug-in/mplayerplug-in/Source/plugin-ui.cpp,v
retrieving revision 1.177
retrieving revision 1.178
diff -C2 -d -r1.177 -r1.178
*** plugin-ui.cpp       26 Nov 2005 15:07:08 -0000      1.177
--- plugin-ui.cpp       30 Nov 2005 13:36:36 -0000      1.178
***************
*** 1513,1516 ****
--- 1513,1517 ----
                                        instance->mediaPercent / 100.0);
 =20
+ #ifdef GTK2_ENABLED
                if (((int) instance->mediaTime > 0)
                    && (instance->showtime =3D=3D 1)) {
***************
*** 1552,1556 ****
                                              display);
                }
!=20
            } else {
                gtk_widget_hide(GTK_WIDGET(instance->mediaprogress_bar));
--- 1553,1558 ----
                                              display);
                }
! #endif
!          =20
            } else {
                gtk_widget_hide(GTK_WIDGET(instance->mediaprogress_bar));



--=20
Get my public GnuPG key from
http://keyserver.veridis.com:11371/export?id=3D7574690260641978351