Re: [Mplayerplug-in-devel] Repeat plays & thread management...
Brought to you by:
kdekorte
From: Kevin D. <kde...@ya...> - 2005-06-14 13:32:27
|
On Monday 13 June 2005 10:51 pm, Nick Phillips wrote: > Hi... > > I've just been playing around with mplayerplug-in to try make it a > bit more robust. > > Basically, I need a player that will embed in a page, provide > controls, and not fall over in any circumstances (we are likely to > use it during exams). > > I have been using 2.80 from debian (rebuilt with gtk2), but it would > hang up if the fwd or rev buttons were pressed while the movie was > stopped. I don't recall whether it would repeat-play or not now, but > I'm sure some previous version I tried wouldn't. > > So, I just started fixing that up when I noticed 2.85 on sf. Since > that version looked like it might have improved in that area, I moved > to that. > > Initially it seemed like it was fixed, but after a little messing > around with different buttons, the play button would fail to start > the thing playing (as before). > > So, I've rejigged the nsPluginInstance::Play() method and > playPlaylist a bit. Since it wasn't at all obvious what the point of > some of the previous code was, I may well have missed something. But > the attached patch works for me (could this be where I find that this > mailing list doesn't do attachments?)... > > The thread management code could really do with a bit more tidying > up, but I'd like to make sure that I'm on the right track first. > > > Cheers, > > > Nick Nick, Well I took a look at this patch and you removed a few lines of code that a= re=20 needed.=20 Looks like you removed the ability to have a media that is autostart=3Dfals= e and=20 then be started when the play button is clicked. The reason controlwindow is in there is for the case where the user is in a= X=20 widget mode and does not have a button to click. Looks like you also moved some code around.. lets see if we can get a clean= er=20 patch and get this solved. Kevin |