Re: [Mplayerplug-in-devel] www.video-c.uk "chart show"

[Kevin D. <kde...@ya...>]

Alex,

I found and fixed it.... was threadsignaled was not being set true after doing 
SignalThread in ::Play...

Committing to CVS now.

Kevin

On Tuesday 16 March 2004 02:16 pm, Alex Eskin wrote:
> Hi Kevin,
>
> I will look at this later tonight.
> I also think this is the final issue to resolve before a release.
>
> Thanks,
>
> Alex
>
> --- Kevin DeKorte <kde...@ya...> wrote:
> > Alex,
> >
> > Ok I have committed a patch that takes out the outer loop. Seems to
> > have the
> > same functionality.
> >
> > One problem that is in the CVS version and was in the eariler one
> > today is
> > that the media will finish clean. You can press play and the media
> > will play
> > again, but on the third time it won't start.
> >
> > I get this on the second try
> > entering loop
> > looking for node to play
> > nothing on the list to play
> > ----player thread: nothing to play
> > ----player thread: normal exit
> > stop clickd
> > play clickd
> > In launchPlayerThread, state = 125
> > ----player thread: in playPlayList
> > ----player thread: about to go to sleep, js_state = 6, state = 125
> > ----player thread: playPlayList - waiting complete
> > ----player thread: building command string
> > PLAY 0:mplayer
> > PLAY 1:-wid
> > PLAY 2:0xc00115
> > PLAY 3:-xy
> > PLAY 4:500
> > PLAY 5:-rtsp-stream-over-tcp
> > PLAY 6:-cache
> > PLAY 7:1024
> > PLAY 8:-vo
> > PLAY 9:xv,x11
> > PLAY 10:-zoom
> > PLAY 11:-osdlevel
> > PLAY 12:0
> > PLAY 13:-nojoystick
> > PLAY 14:-nofs
> > PLAY 15:-slave
> > ----player thread: local_list =  0x86211a8
> > PL URL: file:///music/Weezer/Weezer/09_Holiday.mp3
> > play = 1, cancelled= 0
> > next= (nil)
> > entering loop
> > looking for node to play
> > ----player thread: chose url
> > file:///music/Weezer/Weezer/09_Holiday.mp3
> > ----player thread: playing url:
> > file:///music/Weezer/Weezer/09_Holiday.mp3
> > ----player thread: URL: file:///music/Weezer/Weezer/09_Holiday.mp3
> > Starting: mplayer -wid 0xc00115 -xy 500 -rtsp-stream-over-tcp -cache
> > 1024 -vo
> > xv,x11 -zoom -osdlevel 0 -nojoystick -nofs -slave /tmp/mplayHXeOdj
> > Signalling Player thread, state = 125, js_state = 6
> > ****Player thread did not start correctly****
> >
> >
> > I get this on the third try
> >
> > entering loop
> > looking for node to play
> > nothing on the list to play
> > ----player thread: nothing to play
> > ----player thread: normal exit
> > stop clickd
> > play clickd
> > Signalling Player thread, state = 125, js_state = 0
> > ****Player thread did not start correctly****
> >
> > Any idea what might be the difference? I can't see what is changing
> > js_state,
> > maybe the control_mutex is locked when it should not be?
> >
> > Kevin
> >
> > On Tuesday 16 March 2004 12:49 pm, Alex Eskin wrote:
> > > Hi Kevin,
> > >
> > > I forgot to say: I think you do not need any
> > > ptheread_cleanup_push stuff  with my suggestion.
> > > At the place you make the changes, the lock is
> > > already taken (and in the main thread you don't
> > > need the pthread_cleanup_push since the main
> > > thread never gets cancelled).
> > >
> > > Best,
> > >
> > > A;ex
> > >
> > > --- Kevin DeKorte <kde...@ya...> wrote:
> > > > Alex,
> > > >
> > > > Working on it...
> > > >
> > > > Almost got it...
> > > >
> > > > The pthead pop command is a strange one... did some weird stuff
> >
> > to
> >
> > > > the
> > > > compiler in the local_list == NULL check, so I had to take it
> >
> > out.
> >
> > > > Might need
> > > > to sanity check that one part when I am done.
> > > >
> > > > Kevin
> > > >
> > > > On Tuesday 16 March 2004 12:29 pm, Alex Eskin wrote:
> > > > > Hi Kevin,
> > > > >
> > > > > Sorry, my last message was incomplete. For the "side-effect"
> > > > > in the play callback, you only reset the playlist if
> > > > > js_state == JS_STATE_UNDEFINED
> > > > >
> > > > > Does that sound reasonable?
> > > > > (All I am saying is that you can get the same functionality
> >
> > with a
> >
> > > > > less drastic and more "obviously correct" patch)
> > > > >
> > > > > Best,
> > > > >
> > > > > Alex
> > > > >
> > > > > --- Kevin DeKorte <kde...@ya...> wrote:
> > > > > > Alex,
> > > > > >
> > > > > > It was not that bad and as a nice side effect of this when
> >
> > the
> >
> > > > media
> > > >
> > > > > > is
> > > > > > complete and stopped. The play button now restarts the whole
> > > >
> > > > thing
> > > >
> > > > > > again
> > > > > > without redownloading...
> > > > > >
> > > > > > Cool.
> > > > > >
> > > > > > Kevin
> > > > > >
> > > > > > On Tuesday 16 March 2004 09:46 am, Alex Eskin wrote:
> > > > > > > Sounds scary.
> > > > > > >
> > > > > > > I will probably have some comments later today when
> > > > > > > the site updates.
> > > > > > >
> > > > > > > Best,
> > > > > > >
> > > > > > > Alex
> > > > > > >
> > > > > > > --- Kevin DeKorte <kde...@ya...> wrote:
> > > > > > > > Alex,
> > > > > > > >
> > > > > > > > Ok this site is fixed now...
> > > > > > > >
> > > > > > > > First think I did was to remove the "loop" directive from
> >
> > the
> >
> > > > > > mplayer
> > > > > >
> > > > > > > > command
> > > > > > > > line to see if the site actually worked. And it did with
> >
> > no
> >
> > > > > > problem.
> > > > > >
> > > > > > > > Then I created a new do { .. } while loop in the
> >
> > playPlaylist
> >
> > > > > > > > function that
> > > > > > > > was around the outer loop. This seemed to work except for
> >
> > a
> >
> > > > hang
> > > >
> > > > > > and
> > > > > >
> > > > > > > > then I
> > > > > > > > noticed the pthread push/pop functions you had in there
> >
> > and I
> >
> > > > > > looked
> > > > > >
> > > > > > > > at what
> > > > > > > > those commands did and then I added them to the new outer
> > > >
> > > > loop
> > > >
> > > > > > and
> > > > > >
> > > > > > > > that fixed
> > > > > > > > the hang. I also found a case where the playlist_mutex
> >
> > was
> >
> > > > not
> > > >
> > > > > > being
>
> === message truncated ===
>
>
> __________________________________
> Do you Yahoo!?
> Yahoo! Mail - More reliable, more storage, less spam
> http://mail.yahoo.com