Re: [Mplayerplug-in-devel] Troy trailer crashes Mozilla v1.6 with MPLayerplug-in v2.45?
Brought to you by:
kdekorte
From: Kevin D. <kde...@ya...> - 2004-03-05 14:13:45
|
Alex, Ok I did some quick tests and the results are making me happy.. Found one=20 minor nit, there was a gdk_threads_leave with out a gdk_threads_enter... No= =20 biggie, I just commented it out...=20 Really appreciate you doing this. Kevin On Friday 05 March 2004 06:39 am, Kevin DeKorte wrote: > Alex, > > Ok I have done a quick look over and have patched it in (nice and clean) > and commited it to CVS.. I'll take a closer look at it later today. > > Kevin > > On Friday 05 March 2004 02:02 am, Alex Eskin wrote: > > Hi Kevin, > > > > Sorry about the last patch. I am attaching a correction > > (as a patch agaist the current CVS). I do not know > > for sure if this fixes the problems, but it passed all > > the tests for me so far. > > > > I have to apologize for the size of the patch: I indented some > > code that was not indented as I was trying to debug. > > > > The main points are: > > 1) I was operating under a misconception of what pthread_cancel > > does. I thought it waited under the thread was cancelled, > > but it does not; in fact it returns immediately. To get it > > to wait, one has to use pthread_join after the pthread_cancel. > > The code now does that. (and with this, you should not need > > pthread_testcancels every other line). > > > > 2) There are some suble points about how to make sure that after > > the player thread is cancelled and joined, it does not hold > > any mutexes. The pthread_cleanup_push/pthread_cleanup_pop > > stuff is supposed to take care of that. I followed the example > > in the pthread_cleanup_push man page. > > > > Sorry about all the mess. > > > > Alex > > > > --- Kevin DeKorte <kde...@ya...> wrote: > > > Alex, > > > > > > go to the plugger test site and switch rapidly between AVI and MPEG, > > > barely > > > let the cahcing start or just let a few seconds of the video play. > > > > > > Usually will hang within 3 or 4 switches. > > > > > > Kevin > > > > > > On Thursday 04 March 2004 07:31 pm, Alex Eskin wrote: > > > > I removed the signal before cancel code, and cannot reproduce > > > > the crash. How do you break it? > > > > > > > > Best, > > > > > > > > Alex > > > > > > > > --- Kevin DeKorte <kde...@ya...> wrote: > > > > > Alex, > > > > > > > > > > If I don't signal before cancelling the plugin hangs hard... so I > > > > > need those > > > > > there. I tried with and without... > > > > > > > > > > I STILL have the problem that if you switch video really fast the > > > > > browser will > > > > > hang... Not sure exactly what is causing it yet... it is not a > > > > > crash, it is > > > > > a hang. Something is locked and I can't find it yet... > > > > > > > > > > Kevin > > > > > > > > > > On Thursday 04 March 2004 06:26 pm, Alex Eskin wrote: > > > > > > Kevin, > > > > > > > > > > > > It looks like you are trying to signal the player thread > > > > > > right before you cancel it. I am pretty sure this is not > > > > > > necassary, since pthread_cond_wait is a cancellation point. > > > > > > (man pthread_cancel). > > > > > > > > > > > > Also under the nptl, all blocking > > > > > > system calls are cancellation points, but under the > > > > > > older library (LinuxThreads), not all of them are. > > > > > > So to get it to work on all versions, you need to > > > > > > do > > > > > > pthread_testcancel() > > > > > > fgets( ) > > > > > > pthread_testcancel() > > > > > > > > > > > > (which I think is already beeing done for the most part). > > > > > > > > > > > > Best, > > > > > > > > > > > > Alex > > > > > > > > > > > > --- Kevin DeKorte <kde...@ya...> wrote: > > > > > > > Make your you run those commands under bash, if you are > > > > > > running > > > > > > > > csh > > > > > > > > > > > > they > > > > > > > probably won't work. > > > > > > > > > > > > > > Kevin > > > > > > > > > > > > > > On Thursday 04 March 2004 01:10 pm, Ryan Bruce wrote: > > > > > > > > Kevin, > > > > > > > > > > > > > > > > I realized that the plugin was not getting automatically > > > > > > put in > > > > > > > > my > > > > > > > > > > > > > mozilla directory. For whatever reason, the export MOZHOME > > > > > > > > > > line > > > > > > > > > > > > isn't > > > > > > > > > > > > > > > returning anything. > > > > > > > > set | grep MOZHOME returns MOZHOME=3D(blank) > > > > > > > > > > > > > > > > -Ryan > > > > > > > > > > > > > > > > Kevin DeKorte wrote: > > > > > > > > > Ryan, > > > > > > > > > > > > > > > > > > Ok one last thing to check > > > > > > > > > > > > > > > > > > Do these commands > > > > > > > > > > > > > > > > > > export MOZ=3D`which mozilla`; > > > > > > > > > export MOZHOME=3D`grep MOZILLA_FIVE_HOME=3D ${MOZ} | awk = -F > > > > > > \" > > > > > > > > '{ > > > > > > > > > > > > print $2 > > > > > > > > > > > > > > > > }'`; ldd ${MOZHOME}/mozilla-bin | grep gtk; > > > > > > > > > > > > > > > > > > And tell me the results > > > > > > > > > > > > > > > > > > might also try > > > > > > > > > > > > > > > > > > ldd `which galeon` | grep gtk > > > > > > > > > > > > > > > > > > And see if that does anything. > > > > > > > > > > > > > > > > > > Kevin > > > > > > > > > > > > > > > > > > On Thursday 04 March 2004 12:02 pm, Ryan Bruce wrote: > > > > > > > > >>Kevin, > > > > > > > > >> > > > > > > > > >>Hope this helps. > > > > > > > > >> > > > > > > > > >>>1. OS you are using? > > > > > > > > >> > > > > > > > > >>Slackware9.1 with 2.6.2 > > > > > > > > >> > > > > > > > > >>>2. Browser Version? Mozilla 1.4 > > > > > > > > >> > > > > > > > > >>As well as Galeon 1.3.9 (which sits on top of mozilla, I > > > > > > > > > > think) > > > > > > > > > > > > > >>>3. mplayerplug-in version? 2.45 or CVS current > > > > > > > > >> > > > > > > > > >>~11:00 CVS > > > > > > > > >> > > > > > > > > >>>4. Are you using an RPM or source? > > > > > > > > >> > > > > > > > > >>for mplayerplugin? Source since it's CVS. > > > > > > > > >> > > > > > > > > >>>5. If using source what is your configure command line? > > > > > > > > >> > > > > > > > > >>./configure --with-gecko-sdk=3D/usr/local/lib/gecko-sdk > > > > > > > > >> > > > > > > > > >>>6. What is the output of "grep CFLAGS Makefile" after > > > > > > you > > > > > > > > run > > > > > > > > > > > > configure? > > > > > > > > > > > > > > > >>bash-2.05b$ grep CFLAGS Makefile > > > > > > > > >>CFLAGS=3D -Wall -g -O2 -DXP_UNIX -DMOZ_X11 > > > > > > > > > > > > > > -I/usr/local/lib/gecko-sdk > > > > > > > > > > > > > > > >>-I/usr/local/lib/gecko-sdk/xpcom/include > > > > > > > > >>-I/usr/local/lib/gecko-sdk/nspr/include > > > > > > > > >>-I/usr/local/lib/gecko-sdk/string/include > > > > > > > > >>-I/usr/local/lib/gecko-sdk/embedstring/include > > > > > > > > >>-I/usr/local/lib/gecko-sdk/plugin/include > > > > > > > > >>-I/usr/local/lib/gecko-sdk/java/include > > > > > > -DGECKOSDK_ENABLED > > > > > > > > > > -Iinclude > > > > > > > > > > > > > > > >>-fPIC -I/usr/X11R6/include -DXPCOM_GLUE > > > > > > -DMOZILLA_STRICT_API > > > > > > > > > > > >>-I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include > > > > > > > > > > > > > > -I/usr/include/atk-1.0 > > > > > > > > > > > > > > > >>-I/usr/include/pango-1.0 -I/usr/X11R6/include > > > > > > > > > > > > > > -I/usr/include/freetype2 > > > > > > > > > > > > > > > >>-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include > > > > > > > > > > -pthread > > > > > > > > > > > > > >>-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include > > > > > > > > > > > > > > -DGTK2_ENABLED > > > > > > > > > > > > > > > >>-DGTK_ENABLED > > > > > > > > >> $(CXX) -c $(CFLAGS) plugingate/np_entry.cpp > > > > > > > > >> $(CXX) -c $(CFLAGS) plugingate/npp_gate.cpp > > > > > > > > >> $(CXX) -c $(CFLAGS) plugingate/npn_gate.cpp > > > > > > > > >> $(CXX) -c $(CFLAGS) Source/plugin.cpp > > > > > > > > >> $(CXX) -c $(CFLAGS) Source/plugin-setup.cpp > > > > > > > > >> $(CXX) -c $(CFLAGS) Source/plugin-support.cpp > > > > > > > > >> $(CXX) -c $(CFLAGS) Source/plugin-list.cpp > > > > > > > > >> $(CXX) -c $(CFLAGS) Source/plugin-ui.cpp > > > > > > > > >> $(CXX) -c $(CFLAGS) Source/plugin-threads.cpp > > > > > > > > >> $(CXX) -c $(CFLAGS) Source/nsScriptablePeer.cpp > > > > > > > > >> $(CXX) -c $(CFLAGS) extras/memmem.c > > > > > > > > >> $(CXX) -c $(CFLAGS) extras/strlcat.c > > > > > > > > >> $(CXX) -c $(CFLAGS) extras/strlcpy.c > > > > > > > > >> > > > > > > > > >>>7. What website are you seeing issue on? Troy Trailer at > > > > > > > > >>>www.apple.com/trailers > > > > > > > > >>> > > > > > > > > >>> > > > > > > > > >>>8. You are seeing the crash right away? Yes > > > > =3D=3D=3D message truncated =3D=3D=3D > > > > __________________________________ > > Do you Yahoo!? > > Yahoo! Search - Find what you=C2=92re looking for faster > > http://search.yahoo.com > > ------------------------------------------------------- > This SF.Net email is sponsored by: IBM Linux Tutorials > Free Linux tutorial presented by Daniel Robbins, President and CEO of > GenToo technologies. Learn everything from fundamentals to system > administration.http://ads.osdn.com/?ad_id=1470&alloc_id638&op=3Dclick > _______________________________________________ > Mplayerplug-in-devel mailing list > Mpl...@li... > https://lists.sourceforge.net/lists/listinfo/mplayerplug-in-devel |