Re: [Mplayerplug-in-devel] Playlists
Brought to you by:
kdekorte
From: christian <yl...@co...> - 2003-10-24 20:55:04
|
Well that patch was not really meant for merging anyway. I agree about the advertising, in this case I just removed them because mplayer cant handle them (se previous posts). My idea was not to hardcode the blocklist but to use something like media_filter= fully qualified path to list with items to block Then check if an item was in that list, but I like your idea more. I will have a look to see if I can make something along the lines of what you are suggesting. /Christian On Fri, 2003-10-24 at 22:10, Kevin DeKorte wrote: > Christian, > > Interesting idea. I'm not sure I am going to merge this for only one reason. > Since advertising is pretty much what pays for people to listen to this stuff > over the net, I would prefer not to specifically block it. I guess I feel if > you are getting something for free a little advertising won't kill you. Maybe > a better option would be something that called an external program that > "filtered" the content. That way what content is filtered it controlled by > the user of the program rather that hard coded in the program itself. > > Perhaps something where you pass it a URL and it returns a "blank" line to > remove the url or even an "altered url". Someone else asked for this feature > but I declined since the "altered url" was fixing a broken site. > > something like this > > new config option > > media_filter=fully qualified path to script > > Add this to PluginInstance structure > char media_filter[1024]; > > Add this to the init instance > sprintf(media_filter,"\0"); > > Need to add something to read the option from the config file > > add something like this to "addToList" > > if (strlen(This->media_filter) == 0) { > sprintf(cmd,"%s %s",This->media_filter,This->url); > fp = popen(cmd,"r") > if (fp != NULL) { > // psuedo code > read a line > if line len = 0 then > don't add the url > else > use returned value as the new url > end if > } > } > example media filter script, really basic example. I'm sure someone can make a > better one. > > #!/bin/bash > echo %1 > /tmp/media_filter > grep -v "nhl_promo1.wma" /tmp/media_filter > rm /tmp/media_filter > > or something along that line > > So if you want to code that up I would take that patch. > > Kevin |