Re: [Mpg123-devel] SSE alignment issues between gcc and vc++/intelc

[Thomas O. <tho...@or...>]

Am Tue, 06 May 2008 15:11:58 -0500
schrieb Dan Smith <da...@al...>: 

Thanks for your work! Sadly, I have to lag there in time, because of RL stuff.

> I also added a conditional define if using visual studio of ssize_t and
> uint32_t in mpg123.h, since they are not defined in the MS headers.
> _MSC_VER defined the MS compiler version define.

Why uint32_t ?
And... I'd prefer such missing types definitions to got into a separate header file.
The normal mpg123 build places such stuff into the system-specific config.h file, which is included before anything else in the sources, usually.
I think it makes more sense to have a mpg123_msvc.h which defines the stuff and includes mpg123.h ... just trying to keep the API header as clean/small as possible here.

> Now the mingw libraries and headers can be dropped in and used in VS
> without modification.  Patch is attached.

wondering if that extra stuff really needs to be in mpg123.h itself; the installed mpg123.h at least doesn't need attribute_align_arg as that's useful for compilation of the lib (?).
So one should be able to hide this aligment stuff inside libmpg123 sources.

> Let me know if you need me to look at anything else, cheers!

I'll do when I come around to work on this. Let's see if I manage to pack the windows build improvements into the 1.4.3 bugfix release.


Alrighty then,

Thomas.