Re: [Mlt-devel] ladspa producer review

[Dan D. <da...@de...>]

On Wed, Feb 20, 2013 at 11:09 AM, Brian Matherly <pez...@ya...> wrote:
> Dan,
>
>>I've been wanting some new generators for kdenlive. One thing I want is a simple test tone generator. I thought the ladspa module would provide what I need, but I found that it only supports filters (not producers). So I hacked together an ladspa producer to take advantage of the ladspa effects that don't take input.
>
>>
>>I have a commit staged here:
>>https://github.com/pez4brian/mlt/commit/e99b978de79541ed3d6644f0a828a3efbd54595f
>>
>>Tones can be generated with, for example:
>>melt -producer ladspa.1047 0=1000 1=0.5
>>Of course, there are other effects in ladspa as well, such as square wave and white noise.
>>
>>Would you be willing to offer your opinion? Besides general style and correctness, I'd also be interested in your opinion on strategy. Is this the best way to get a test tone generator? Is it ok to hack up the code that was borrowed from jackrack? Would SOX be a better way to go?
>>
>>If we land on somethink we like, I'd be happy to pull it into the mltframework repository.
>
>
> Have you had a chance to peek at this yet?

No, I am giving my full attention to the GLSL branch at the moment
because that is overdue since last February and so close to merging.

> I accidentally pushed it to the MLT repo. Let me now if I should revert it.
> https://github.com/mltframework/mlt/commit/e99b978de79541ed3d6644f0a828a3efbd54595f

I do not expect this to be a big deal. I do think it makes sense to
have LADSPA producers as well as SoX, contribution willing. It is also
ok to change the code inherited from jackrack now because we are not
trying to keep it in sync with the original project, and it appears
there may be little benefit in doing so.

-- 
+-DRD-+