[Mlt-devel] [PATCH 5/8] mlt_consumer.c: watch out for null pointer

[Mikko R. <mik...@ik...>]

Fixes Coverity CID 709393: Dereference before null check (REVERSE_INULL)
Directly dereferencing pointer "profile".
 235                profile->sample_aspect_num = mlt_properties_get_int( properties, "sample_aspect_num" );
Dereferencing "profile" before a null check.
 236                if ( profile )
---
 src/framework/mlt_consumer.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/framework/mlt_consumer.c b/src/framework/mlt_consumer.c
index 9ff244b..de53a58 100644
--- a/src/framework/mlt_consumer.c
+++ b/src/framework/mlt_consumer.c
@@ -232,9 +232,11 @@ static void mlt_consumer_property_changed( mlt_properties owner, mlt_consumer se
 	{
 		mlt_properties properties = MLT_CONSUMER_PROPERTIES( self );
 		mlt_profile profile = mlt_service_profile( MLT_CONSUMER_SERVICE( self ) );
-		profile->sample_aspect_num = mlt_properties_get_int( properties, "sample_aspect_num" );
 		if ( profile )
+		{
+			profile->sample_aspect_num = mlt_properties_get_int( properties, "sample_aspect_num" );
 			mlt_properties_set_double( properties, "aspect_ratio", mlt_profile_sar( profile )  );
+		}
 	}
 	else if ( !strcmp( name, "sample_aspect_den" ) )
 	{
-- 
1.7.10.4