Re: [Mlt-devel] [PATCH] Fix Kdenlive title module breaking locale

[j-b-m <j-...@us...>]

On Thursday 08 September 2011 19:22:48 j-b-m wrote:
> On Thursday 08 September 2011 15:38:09 j-b-m wrote:
> > setlocale(LC_NUMERIC,"POSIX");
> > 
> > 
> > Of course, that caused major problems in MLT when used in non english
> > locales. I think it might be the reason for the strange reports on the
> > forum about using an image in a title clip that made a track
> > disappear...
> > 
> > 
> > Anyways, attached is a patch that fixes this behaviour as well as
> > kdenlive issue 2304.
> 
> Hmm, my patch doesn't seem to work in all cases, I have to work on it a
> little bit more, will come back to you when it's ready...

Ok, here is my last try. The patch contains the locale fix and a few cleanups 
for the kdenlivetitle producer... that code really needed it.

So basically, instead of doing:

setlocale(LC_NUMERIC,"POSIX");

We fetch MLT's locale like that:

const char *localename = mlt_properties_get_lcnumeric( MLT_SERVICE_PROPERTIES( 
MLT_PRODUCER_SERVICE( producer ) ));

And set it on our Qt instance:

QLocale::setDefault( QLocale( localename ) );

I also added the possibility to set the locale from the kdenlivetitle xml 
attribute LC_NUMERIC so that you can play a title xml from another locale.

regards
jb