[Mlt-devel] Possible errors in your source code

[Patrick M. <pma...@de...>]

Hello,

I have done an automatig source code check with cppcheck 1.44 for your
source code and get the following result:
[./mlt-0.5.10/src/framework/mlt_geometry.c:654]: (error) Common realloc
mistake: "ret" nulled but not freed upon failure
[./mlt-0.5.10/src/modules/dgraft/filter_telecide.c:139]: (error)
Undefined behaviour: buf is used wrong in call to sprintf or snprintf.
Quote: If copying takes place between objects that overlap as a result
of a call to sprintf() or snprintf(), the results are undefined.
[./mlt-0.5.10/src/modules/dgraft/filter_telecide.c:141]: (error)
Undefined behaviour: buf is used wrong in call to sprintf or snprintf.
Quote: If copying takes place between objects that overlap as a result
of a call to sprintf() or snprintf(), the results are undefined.
[./mlt-0.5.10/src/modules/dgraft/filter_telecide.c:142]: (error)
Undefined behaviour: buf is used wrong in call to sprintf or snprintf.
Quote: If copying takes place between objects that overlap as a result
of a call to sprintf() or snprintf(), the results are undefined.
[./mlt-0.5.10/src/modules/gtk2/producer_pango.c:191]: (error) Common
realloc mistake: "markup" nulled but not freed upon failure
[./mlt-0.5.10/src/modules/gtk2/producer_pixbuf.c:149]: (error) Resource
leak: fd
[./mlt-0.5.10/src/modules/jackrack/plugin.c:529]: (error) Memory leak:
instances
[./mlt-0.5.10/src/modules/jackrack/process.c:433]: (error) Mismatching
allocation and deallocation: full_port_name
[./mlt-0.5.10/src/modules/melt/producer_melt.c:59]: (error) Resource
leak: input
[./mlt-0.5.10/src/modules/qimage/producer_qimage.c:123]: (error)
Resource leak: fd
[./mlt-0.5.10/src/modules/vorbis/producer_vorbis.c:184]: (error) Memory
leak: metadata
[./mlt-0.5.10/src/modules/xml/producer_xml.c:1337]: (error) Resource leak: f
[./mlt-0.5.10/src/modules/xml/producer_xml.c:1354]: (error) Memory leak: sax
[./mlt-0.5.10/src/modules/xml/producer_xml.c:1356]: (error) Memory leak:
context
[./mlt-0.5.10/src/modules/xml/producer_xml.c:509]: (error) Dangerous
usage of 'temp' (strncpy doesn't always 0-terminate it)

Please note, that I did not verify, if the errors are a false positive,
or not. Please check it, thanks!
-- 
/*
Mit freundlichem Gruß / With kind regards,
 Patrick Matthäi
 GNU/Linux Debian Developer

E-Mail: pma...@de...
        pa...@li...

Comment:
Always if we think we are right,
we were maybe wrong.
*/