Re: [Mlt-devel] release plans
Brought to you by:
ddennedy,
lilo_booter
From: Dan D. <da...@de...> - 2008-07-09 17:21:18
|
On Wed, Jul 9, 2008 at 9:09 AM, j-b-m <j-...@us...> wrote: > On Wednesday 09 July 2008 16:21:48 Dan Dennedy wrote: >> On Tue, Jul 8, 2008 at 11:38 AM, j-b-m <j-...@us...> wrote: > >> I can confirm the qt3 and kde stuff still configures, builds, and >> works with the patch applied. A brief review looks fine with me. > > Ok, so if there is no objection, I will commit later today. No objection. > By the way I now also included in my patch the last 2 fixes commited to pixbuf > producer regarding image sequences (revision 1128 and 1108) so that we have > the same fixes in qimage producer. Sounds good. > By the way I got frequent crashes these days when playing in Kdenlive that > seem related to deletion of video_context. Backtrace below if it helps. > > 0xb7fb4d4c in mlt_properties_get_data (this=0x8903470, name=0xb7fc6658 > "_events", > length=0x0) at mlt_properties.c:293 > 293 if ( list->count > 0 && > Current language: auto; currently c > > > Thread 9 (Thread 0xaf977b90 (LWP 8206)): > #0 0xb7fb4d4c in mlt_properties_get_data (this=0x8903470, name=0xb7fc6658 > "_events", > length=0x0) at mlt_properties.c:293 > ---Type <return> to continue, or q <return> to quit--- > #1 0xb7fb89f4 in mlt_events_fire (this=0xe, id=0xb7fc61f1 "property-changed") > at mlt_events.c:379 > #2 0xb7fb5e9a in mlt_properties_set_data (this=0x8903470, > name=0xb40c1bcc "video_context", value=0x0, length=0, destroy=0, > serialise=0) > at mlt_properties.c:721 I seem to recall having a similar problem in the other location in producer_avformat.c where I re-open the file. To fix that, I suspend events. Can you test the following patch? Index: src/modules/avformat/producer_avformat.c =================================================================== --- src/modules/avformat/producer_avformat.c (revision 1157) +++ src/modules/avformat/producer_avformat.c (working copy) @@ -76,9 +76,11 @@ } // Close the file to release resources for large playlists - reopen later as needed + mlt_events_block( properties, this ); mlt_properties_set_data( properties, "dummy_context", NULL, 0, NULL, NULL ); mlt_properties_set_data( properties, "audio_context", NULL, 0, NULL, NULL ); mlt_properties_set_data( properties, "video_context", NULL, 0, NULL, NULL ); + mlt_events_unblock( properties, this ); } } -- +-DRD-+ |