Re: [mh] Pushover.net Interface

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 454-5900

Hi Roger,

Simple fix:

diff --git a/lib/Pushover.pm b/lib/Pushover.pm
index f68af87..4c4fa27 100644
--- a/lib/Pushover.pm
+++ b/lib/Pushover.pm
@@ -177,7 +177,7 @@ sub notify {
 
     # Copy the calling hash since we need to modify it.
     if ( defined $params ) {
-        foreach ( keys $params ) {
+        foreach ( keys %{$params} ) {
             next if ( $_ eq 'disable' );   # internal override, not for
pushover
             $callparms->{$_} = $params->{$_};
         }

I need to tell perl that $params is actually a hash ref,    By
surrounding the $params   with %{..}   perl is happy.

I think I also need to add some validations to log errors if either
Pushover->new()  or ->notify() are called with and invalid hash or that
will crash as well.  What really threw me is the line numbers were off
for some reason.

Thanks for the feedback.

George

On 02/16/2014 09:33 PM, George Clark wrote:
> Hi Roger,
>
> That's really strange, it's been all working here fine. The line number
> reported doesn't seem to line up to what's in github.
>
> https://github.com/gac410/misterhouse/blob/Pushover/lib/Pushover.pm#L169
>
> Could you also show me how you are calling the notify()? It's important
> to pass in the optional parameters as a perl hash. Here are 3 examples,
> a single option, two options, and one with no optional parameters
>
> $push->notify("Test motion 1", { priority => 2 } );
> $push->notify("Test motion 2", { priority => -1, title => 'trivial msg'} );
> $push->notify("Test motion 3");
>
> What version of perl are you using?
>
> George
>
> On 02/16/2014 04:14 PM, famille wrote:
>> Hello 
>> I have tried to implement your code  but I have  following error when
>> activate Pushover.pm via use Pushover 
>> I may have missed something 
>>
>> Type of arg 1 to keys must be hash (not private variable) at
>> /usr/local/mh/bin/../lib/Pushover.pm line 169, near "$params ) "
>> Compilation failed in require at (eval 368) line 8188.
>>
>> Regards 
>>
>> Roger 
>>
>> -----Message d'origine-----
>> De : Lieven Hollevoet [mailto:li...@li...] 
>> Envoyé : dimanche 16 février 2014 21:21
>> À : George Clark
>> Cc : The main list for the MisterHouse home automation program
>> Objet : Re: [mh] Pushover.net Interface
>>
>> Hey George,
>>
>> OK, I’ll leave the pull request open for feedback from others then.
>>
>> I do plan to experiment with your interface, however, I first need to find
>> some spare time :-)
>>
>> Kind regards,
>>  Lieven.
>>
>> Op 16-feb.-2014, om 21:18 heeft George Clark <ge...@fe...> het
>> volgende geschreven:
>>
>>> Hi Lieven,
>>>
>>> One of the reasons I put it out there is to get feedback, and see if 
>>> it's working for anyone else.  This is my first interface, so I expect 
>>> that there are things I could have done better.
>>>
>>> So for what I've tested, I think it all seems okay.  I don't have much 
>>> actually pushing any notifications yet other than some test code.  And 
>>> I don't have an audio enabled system, so other than log messages, I 
>>> don't really know if the "speak" actions are working.
>>>
>>> My next challenge is to get my arduino uno to monitor a bunch of contact
>>> closures - doors, sump floats, smoke alarms, etc.     Thats what will
>>> drive most of the Pushover notifications.    Unfortunately I've not come
>>> up with any good examples of Arduino integration with mh.   The
>>> pytomation arduino sketch contributed by george farris works great,  
>>> but not with mh.   I'm toying with building a simple arduino <-> xPL
>>> bridge to run on a Raspberry Pi.   And trigger mh events with xPL.    
>>>
>>> I like what I see in pytomation, but it is proving to me that I'm NOT a
>>> python programmer.    I'm a lot more comfortable with perl. 
>>>
>>> Thanks,
>>> George
>>>
>>>
>>> On 02/16/2014 03:00 PM, Lieven Hollevoet wrote:
>>>> Hey George,
>>>>
>>>> sure, no problem to amend it. The idea of having a separate branch for a
>> feature that you add is that you can keep adding changes, even after you
>> made the pull request. Next to that, others can also easily test your
>> proposed changes by checking out that branch.
>>>> Your new changes are included in the branch ‘add_pushover_support’ and
>> are included in the pull request. Just let me know if everything is OK for
>> master.
>>>> Kind regards,
>>>> Lieven.
>>>>
>>>> Op 16-feb.-2014, om 16:04 heeft George Clark <ge...@fe...> het
>> volgende geschreven:
>>>>> Hi Lieven,
>>>>>
>>>>> Last night I made a second checkin that added a Pushover_disable 
>>>>> parameter, and also tweaked a few more things here and there.  I 
>>>>> think I'm finally done for now.
>>>>>
>>>>> I commented on your pull request with the 2nd commit.  I didn't see any
>>>>> way for me to add it to the pull request.   If you can't amend it, let
>>>>> me know and I'll create another request a bit later. 
>>>>>
>>>>> George
>>>>>
>>>>> On 02/16/2014 04:38 AM, Lieven Hollevoet wrote:
>>>>>> Hey George,
>>>>>>
>>>>>> I have cherry-picked your change and created a pull request against
>> hollie/master (for more on how to do this see here:
>> https://github.com/hollie/misterhouse/wiki/Contributing). 
>>>>>> Can you please review it? If it is OK for you we will merge it into
>> master so it becomes part of the code for the next stable release.
>>>>>> The pull request is here: 
>>>>>> https://github.com/hollie/misterhouse/pull/373
>>>>>>
>>>>>> Best regards,
>>>>>> Lieven.
>>>>>>
>>>>>> Op 15-feb.-2014, om 17:20 heeft George Clark <ge...@fe...> het
>> volgende geschreven:
>>>>>>> Hi all,
>>>>>>>
>>>>>>> I've checked in a new interface for sending messages to the 
>>>>>>> Pushover.net notification service.
>>>>>>>
>>>>>>> https://github.com/gac410/misterhouse/commit/61631c7ef26f89f85656c
>>>>>>> 790b4ecb4ce6f094adf
>>>>>>>
>>>>>>> It supports much of the Pushover API, including setting message 
>>>>>>> priority and checking for acknowledgments for priority 2 - 
>>>>>>> emergency priority messages.  It also performs some rudimentary 
>>>>>>> rate limiting, blocking duplicate messages sent in a 60 second window.
>>>>>>>
>>>>>>> It's on a branch forked from KRKeegan's  InsteonIP branch.  It 
>>>>>>> doesn't use anything else from that branch though.  It should work 
>>>>>>> on master as well.  I just happen to be running that branch in my git
>> checkout.
>>>>>>> I wasn't sure about the process for contributing code.  It passes 
>>>>>>> perlcritic and is formatted with perltidy default settings.
>>>>>>>
>>>>>>> George
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> ------------------------------------------------------------------
>>>>>>> ------------
>>>>>>> Android apps run on BlackBerry 10
>>>>>>> Introducing the new BlackBerry 10.2.1 Runtime for Android apps.
>>>>>>> Now with support for Jelly Bean, Bluetooth, Mapview and more.
>>>>>>> Get your Android app in front of a whole new audience.  Start now.
>>>>>>> http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/o
>>>>>>> stg.clktrk 
>>>>>>> ________________________________________________________
>>>>>>> To unsubscribe from this list, go to: 
>>>>>>> https://lists.sourceforge.net/lists/listinfo/misterhouse-users
>>>>>>>
>
> ------------------------------------------------------------------------------
> Android apps run on BlackBerry 10
> Introducing the new BlackBerry 10.2.1 Runtime for Android apps.
> Now with support for Jelly Bean, Bluetooth, Mapview and more.
> Get your Android app in front of a whole new audience.  Start now.
> http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk
> ________________________________________________________
> To unsubscribe from this list, go to: https://lists.sourceforge.net/lists/listinfo/misterhouse-users
>



