From: Lieven H. <li...@li...> - 2014-02-16 20:00:59
|
Hey George, sure, no problem to amend it. The idea of having a separate branch for a feature that you add is that you can keep adding changes, even after you made the pull request. Next to that, others can also easily test your proposed changes by checking out that branch. Your new changes are included in the branch ‘add_pushover_support’ and are included in the pull request. Just let me know if everything is OK for master. Kind regards, Lieven. Op 16-feb.-2014, om 16:04 heeft George Clark <ge...@fe...> het volgende geschreven: > Hi Lieven, > > Last night I made a second checkin that added a Pushover_disable > parameter, and also tweaked a few more things here and there. I think > I'm finally done for now. > > I commented on your pull request with the 2nd commit. I didn't see any > way for me to add it to the pull request. If you can't amend it, let > me know and I'll create another request a bit later. > > George > > On 02/16/2014 04:38 AM, Lieven Hollevoet wrote: >> Hey George, >> >> I have cherry-picked your change and created a pull request against hollie/master (for more on how to do this see here: https://github.com/hollie/misterhouse/wiki/Contributing). >> >> Can you please review it? If it is OK for you we will merge it into master so it becomes part of the code for the next stable release. >> The pull request is here: https://github.com/hollie/misterhouse/pull/373 >> >> Best regards, >> Lieven. >> >> Op 15-feb.-2014, om 17:20 heeft George Clark <ge...@fe...> het volgende geschreven: >> >>> Hi all, >>> >>> I've checked in a new interface for sending messages to the Pushover.net >>> notification service. >>> >>> https://github.com/gac410/misterhouse/commit/61631c7ef26f89f85656c790b4ecb4ce6f094adf >>> >>> It supports much of the Pushover API, including setting message priority >>> and checking for acknowledgments for priority 2 - emergency priority >>> messages. It also performs some rudimentary rate limiting, blocking >>> duplicate messages sent in a 60 second window. >>> >>> It's on a branch forked from KRKeegan's InsteonIP branch. It doesn't >>> use anything else from that branch though. It should work on master as >>> well. I just happen to be running that branch in my git checkout. >>> >>> I wasn't sure about the process for contributing code. It passes >>> perlcritic and is formatted with perltidy default settings. >>> >>> George >>> >>> >>> >>> ------------------------------------------------------------------------------ >>> Android apps run on BlackBerry 10 >>> Introducing the new BlackBerry 10.2.1 Runtime for Android apps. >>> Now with support for Jelly Bean, Bluetooth, Mapview and more. >>> Get your Android app in front of a whole new audience. Start now. >>> http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk >>> ________________________________________________________ >>> To unsubscribe from this list, go to: https://lists.sourceforge.net/lists/listinfo/misterhouse-users >>> > |