From: Lieven H. <li...@li...> - 2012-11-06 20:55:27
|
Hi Jim, Op 6-nov.-2012, om 21:47 heeft Jim Duda <ji...@du...> het volgende geschreven: > I think I did a pull request for both the master and insteon branches, but I'm > not fully sure. For some reason, the description didn't fill in on one of > the requests, I didn't catch that at first. > Yes, noticed them. The insteon pull request I accepted, the one for the master branch did not work as as I had hoped it would be so I had to refuse it. I'm afraid for the time being we will need to ask you to apply the changes you make to the two branches as you did with SVN... > I believe I have done one round of git. To be honest, I find this to be > a lot of work. But, I do understand how this will make it easier for others > to contribute where SVN is a stumbling block. I'm sure it will get easier > as I get more practice. I'm sure it will :-) By the way, if you're regularly contributing code and you feel confident enough to use git, I can/will add you as contributor to the main fork (on my account). Then you clone this repo, make a branch, commit and push the change back to github in one operation. No need to go for a pull request in that case. Just let me know if you want this type of access. > > I see that you have accepted my changes. Is it now the proper time to delete > the android_callerid branch from my local git repository? > As stated, only for the insteon branch and not for the master. I would like to ask you if you would see it feasible to make the same change on the master branch? > Thanks for you help. Thanks for you effort and the sharing of your code! Kind regards, Lieven. |