Re: [mh] Insteon Engine Version

[Marc M. <ma...@me...>]

On Sat, Nov 03, 2012 at 07:53:12PM +0100, Lieven Hollevoet wrote:
> I'm not the Insteon specialist, but the changes you propose in your pull request are indeed minor, so as a proof of concept I have merged them with the master branch without waiting for approval by the other team members (this is the first and only time I will do this).
 
While I would love for a few other people to join as reviewers, my default
take is that any diff to a driver that has no other maintainer and virtually
no users should be approved for now.
As Linus says, it's better to have a somewhat broken driver, than no driver
at all :)

As a side note, it's hard to review code for a device you don't have, or a
protocol you don't know anyway.

> What I would also suggest is that when somebody creates a pull request, that this person also communicates it to this mailing list with a link to the web page showing the diff of the request (similar to the link I provided above). This ensures that people who could be interested in the request but who are not subscribed to mail notifications of the MH git repo also see the pull request passing by.

Sounds like a good idea.

Marc
-- 
"A mouse is a device used to point at the xterm you want to type in" - A.S.R.
Microsoft is to operating systems ....
                                      .... what McDonalds is to gourmet cooking
Home page: http://marc.merlins.org/