[misterhouse-users] Bug in $Season calculation

[Mike a. S. P. <the...@ya...>]

After a motion sensor I've got controlling a heater in
my basement stopped working yesterday, I did some
debugging and found some incorrect code in MH that
others should probably be aware of.

I'm just starting out in HA and MH, and don't yet have
a lot of the functionality I'd like to, namely the
IButton temperature monitors everyone's been posting
info on.  The best I could come up with was keying off
the $Season - only turning the heater on in the
Winter.

Starting yesterday, MH was reporting that the Season
was Summer.  After doing some investigation, I found
the following offending code:

my @seasons = split(',', $config_parms{seasons});
if (($Month < 4 and $Mday < 20) or
    ($Month == 12 and $Mday > 20)) {
   $Season = $seasons[0];
   }
elsif ($Month < 7 and $Mday < 21) { ...

It works fine except for the days >= 20 in Jan and
Feb.

The correct code should be:

if ($Month < 3 or
    ($Month == 3 and $Mday < 20) or
    ($Month == 12 and $Mday > 20)) {
...

Mike Pearce

__________________________________________________
Do You Yahoo!?
Yahoo! Auctions - Buy the things you want at great prices. 
http://auctions.yahoo.com/