Re: [Mingw-w64-public] PATCH for autootools to use genlib

[Martell M. <mar...@gm...>]

Thanks for your input and help on this.
Please review :)

On Sun, Nov 8, 2015 at 10:05 PM, NightStrike <nig...@gm...> wrote:

> ...and, as such, you have to provide a way to set the name.
> --with-genlib=mygenlib.  You can find examples of this elsewhere in
> the build system.  This means that you don't call AC_CHECK_TOOL until
> after the with- processing, and only if with_genlib is not set to no.
> AS_CASE is appropriate for that checking.
>
> On Mon, Nov 9, 2015 at 1:02 AM, NightStrike <nig...@gm...> wrote:
> > Sorry, missed this the first time around... this should be a with-
> > option, not enable.  genlib is an external tool for the crt, not an
> > internal feature that is getting compiled in.  You should just have to
> > change to AC_ARG_WITH and from enable_ to with_.
> >
> > On Mon, Nov 9, 2015 at 12:46 AM, Martell Malone <mar...@gm...>
> wrote:
> >> Here is the final patch after running autoreconf -fi and only applying
> >> relevant changes.
> >> I would like to apply this if there are no objections ?
> >>
> >> Kind Regards
> >> Martell
> >>
> >> On Fri, Nov 6, 2015 at 3:39 PM, Martell Malone <mar...@gm...
> >
> >> wrote:
> >>>
> >>> Updated to reflect Nightstrike's feedback
> >>>
> >>> On Wed, Nov 4, 2015 at 2:00 PM, NightStrike <nig...@gm...>
> wrote:
> >>>>
> >>>> Use AM_CONDITIONAL, not DEFINE_UNQUOTED
> >>>>
> >>>> On Wed, Nov 4, 2015 at 1:56 PM, Martell Malone <
> mar...@gm...>
> >>>> wrote:
> >>>> > Be warned I am no autotools expert.
> >>>> > A review would be very helpful. :)
> >>>> >
> >>>> > CC+ alexey for help on that :)
> >>>> >
> >>>> >
> >>>> >
> >>>> >
> ------------------------------------------------------------------------------
> >>>> >
> >>>> > _______________________________________________
> >>>> > Mingw-w64-public mailing list
> >>>> > Min...@li...
> >>>> > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
> >>>> >
> >>>>
> >>>>
> >>>>
> ------------------------------------------------------------------------------
> >>>> _______________________________________________
> >>>> Mingw-w64-public mailing list
> >>>> Min...@li...
> >>>> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
> >>>
> >>>
> >>
> >>
> >>
> ------------------------------------------------------------------------------
> >> Presto, an open source distributed SQL query engine for big data,
> initially
> >> developed by Facebook, enables you to easily query your data on Hadoop
> in a
> >> more interactive manner. Teradata is also now providing full enterprise
> >> support for Presto. Download a free open source copy now.
> >> http://pubads.g.doubleclick.net/gampad/clk?id=250295911&iu=/4140
> >> _______________________________________________
> >> Mingw-w64-public mailing list
> >> Min...@li...
> >> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
> >>
>
>
> ------------------------------------------------------------------------------
> Presto, an open source distributed SQL query engine for big data, initially
> developed by Facebook, enables you to easily query your data on Hadoop in a
> more interactive manner. Teradata is also now providing full enterprise
> support for Presto. Download a free open source copy now.
> http://pubads.g.doubleclick.net/gampad/clk?id=250295911&iu=/4140
> _______________________________________________
> Mingw-w64-public mailing list
> Min...@li...
> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
>