From: Ozkan S. <se...@gm...> - 2014-07-26 14:40:05
|
On 7/26/14, dw <lim...@ya...> wrote: > Well, since no one else has responded, what would you say to this > (attached)? > > If you like, I can write up a detailed description about why I believe > this is the way to go, but hopefully the comments and code speak for > themselves. This should give the correct definitions for 32bit, LP64 > and LLP64. > > If this is approved, someone else will have to commit it. git is not my > thing. Kai and/or Jon should be approving or rejecting this. > > dw > > On 7/20/2014 2:18 AM, Ozkan Sezer wrote: >> Regarding gcc PR target/61662: >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61662 >> http://gcc.gnu.org/viewcvs/gcc?view=revision&sortby=date&revision=212826 >> >> In our intrin.h (and stdlib.h), we are overriding the definitions >> from ia32intrin.h possibly the original definition from gcc used >> to be wrong with relation to _LLP64? Even if that were the case, >> what we have is wrong because _lrotl and _lrotr accept and return >> unsigned long for both win32 _and_ win64, and for windows that is >> strictly 32 bits. We need to fix this. >> >> -- >> O.S. >> > > |