From: Ozkan S. <se...@gm...> - 2011-05-21 09:43:14
|
On Sat, May 21, 2011 at 10:09 AM, Kai Tietz <kti...@go...> wrote: > 2011/5/21 Ozkan Sezer <se...@gm...>: >> On Sat, May 21, 2011 at 9:56 AM, Kai Tietz <kti...@go...> wrote: >>> 2011/5/21 Dongsheng Song <don...@gm...>: >>>> On Thu, May 19, 2011 at 15:28, Dongsheng Song <don...@gm...> >>>> wrote: >>>>> >>>>> 于 2011-5-19 15:14, Ozkan Sezer 写道: >>>>> > On Thu, May 19, 2011 at 9:51 AM, Dongsheng Song >>>>> > <don...@gm...> wrote: >>>>> >> Hi, >>>>> >> >>>>> >> There have 69 functions both in libmingwex and 64 bit msvcr90.dll, >>>>> >> 50 functions both in libmingwex and 32 bit msvcr90.dll, all of them >>>>> >> should mark by DATA. >>>>> >> >>>>> >> PS: I'm using VS 2008 SP1 runtime to generate the .DEF files. >>>>> >> >>>>> >> ChangeLog | 22 ++++++++ >>>>> >> lib32/msvcr90.def | 122 >>>>> >> +++++++++++++++++++++++----------------------- >>>>> >> lib64/msvcr90.def | 142 >>>>> >> +++++++++++++++++++++++++++--------------------------- >>>>> >> 3 files changed, 154 insertions(+), 132 deletions(-) >>>>> >> >>>>> >>>> >>>> ping:-) >>>> >>>> Without this patch, I can not compile cx-Oracle. Due to the official >>>> python-2.7 distro use msvcr90.dll, >>>> then when I compile cx-Oracle, setup.py will link libmsvcr90.a >>>> automatically, failed on symbols conflict. >>>> >>>> With this patch, I can build and test cx-Oracle smoothly. >>>> >>>> -- >>>> Dongsheng >>> >>> AFAICS is the patch for msvcr90 ok. The DATA marking looks right. >>> Ozkan, what are your concerns here in details? >>> >>> Regards, >>> Kai >> >> No concerns, really. I only wondered why the fixme notes were >> removed and he said that gendef itself didn't generate the fixmes >> (why, I don't know..). So I'm OK. >> >> -- >> Ozkan > > Well, it might be that those functions can be determined by his > version of msvcr90.dll. But indeed this looks a bit strange. But well, > as it looks sane and he confirms that it works for him, I am ok by it, > too. > > Regards, > Kai Alright, apply away. -- O.S. |