Re: [Mingw-w64-public] command line globbing

[Kai T. <Kai...@on...>]

Ozkan Sezer <se...@gm...> wrote on 03.01.2010 15:16:40:

> On Sun, Jan 3, 2010 at 3:35 PM, Ozkan Sezer <se...@gm...> wrote:
> > On Sun, Jan 3, 2010 at 12:57 PM, Kai Tietz <kti...@go...> 
wrote:
> >> Hi Ozkan,
> >>
> >> 2010/1/3 Ozkan Sezer <se...@gm...>:
> >>> kmx came up with this issue:
> >>>
> >>> ---------- Forwarded message ----------
> >>> From: SourceForge.net <no...@so...>
> >>> Date: Sat, Jan 2, 2010 at 11:04 AM
> >>> Subject: [mingw-w64 - Help] RE: 64-bit native toolchain binaries
> >>>
> >>> Read and respond to this message at:
> >>> https://sourceforge.net/projects/mingw-
> w64/forums/forum/723798/topic/3436580
> >>>
> >>>> **1) strip.exe issue (maybe it is a feature)**
> >>>>
> >>>> With old gcc toolchain from mingw.org project I can run
> >>>> strip.exe with a wildcard like this: strip d:\dir\*.dll
> >>>>
> >>>> However with mingw-w64 binaries it returns:
> >>>> d:\> strip.exe d:\dir\*.dll
> >>>> strip.exe: 'd:\dir\*.dll': No such file
> >>>> (even if there are *.dll files in d:\dir)
> >>>>
> >>>> Maybe it is a new feature of new biutils, I do not know.
> >>>> Anyway the behaviour of the old toolchain was more
> >>>> convenient.
> >>>
> >>> Hmm, command line parsing/glob'bing seem to not
> >>> work. I beleive, if you were to run it under msys instead
> >>> of cmd.exe it would work. The reason may be that
> >>> our crt disables globbing by default (see crt/wildcard.c,
> >>> also see crt/CRT_glob.c), whereas the mingw.org crt
> >>> enables it by default. I am not sure whether we should
> >>> enable it. Kai?
> >>>
> >>> *******
> >>>
> >>> What do you guys think? Should we enable cmdline globbing
> >>> by default as the mingw32 guys do?
> >>>
> >>> --
> >>> Ozkan
> >>>
> >>
> >> Well, we can do. But we should provide then the object for disabling
> >> it as .o file, too.
> >>
> >> Fine by me.
> >>
> >> Cheers,
> >> Kai
> >
> > OK, I made the attached patch, against the 1.0 branch,
> > also applies to the trunk.  It keeps the old behavior,
> > which is globbing off by default, but adds a new configure
> > option --enable-wildcard which enables it.  It also adds
> > CRT_noglob.c which gives the means of disabling globbing,
> > like its counterpart CRT_glob.c. The patch doesn't include
> > the diffs to the generated files.  If the patch is OK, I
> > can apply it to the 1.0 branch and to the trunk, and can
> > also regenerate the necessary files, or nightstrike can do
> > it himself (the three commands autoheader, autoconf and
> > automake must be run.)
> >
> > --
> 
> OK, here is a better diff.  Previous one was messed up somehow..

Thank you. For me this patch looks ok. Of course configure/makefile needs 
update then. If you tested it (as I assume) this patch is ok from my side.

Thanks,
Kai

|  (\_/)  This is Bunny. Copy and paste Bunny
| (='.'=) into your signature to help him gain
| (")_(") world domination.