Re: [Ming-dev] [patch] Fix a buffer overflow.

[Sandro S. <st...@ke...>]

On Mon, May 05, 2014 at 01:25:28PM +0200, Bastiaan Jacques wrote:
> On Mon, 5 May 2014, Sandro Santilli wrote:
> 
> >Receives optarg as the one you patched. Why did yours need patching ?
> 
> If the reasons for my patch weren't clear, why did you ask me to modify it
> and then to publish it in a git repo?

I understood, from the commit log, that your patch was to fix a possible
overflow [ I guess the sizeof(char*) ] but also a possible misuse of optarg.

I hadn't made deep research on the latter, but for consistency if optarg
can really not be counted on as pointing to immutable space for the whole
duration of the executable the same applies to the other function too.

See if 862720a44eb311f943a19b3ae4f9c46698ab708d is enough :)

--strk;