Re: [Mesa3d-dev] texutil updates

[Gareth H. <ga...@va...>]

Brian Paul wrote:
> 
> Don't remove the original case.
> 
> GL_BGR / GL_UNSIGNED_SHORT_5_6_5_REV is equivalent to GL_RGB /
> GL_UNSIGNED_SHORT_5_6_5.  In both cases, the component packing
> in the GLushort is RRRRRGGGGGGBBBBB.
> 
> So, the condition should be:
> 
>  if ((srcFormat == GL_RGB && srcType == GL_UNSIGNED_SHORT_5_6_5) ||
>      (srcFormat == GL_BGR && srcType == GL_UNSIGNED_SHORT_5_6_5_REV)) {

Hmmm...  I'm going to have to read the spec a little more closely.  Given the
fact that it's 4:30am over here this is frying my brain ;-)

Either way, I agree that having both cases is useful.  I should said "add" not
"change to".

-- Gareth