From: Ken W. <ke...@fo...> - 2001-09-26 16:50:47
|
John Williams <wil...@mo...> wrote: > One layout comment: If you moved HTML::Mason::Buffer to the outside, > you could route a couple arrows through there along much straighter > paths. GraphViz doesn't give you direct control over the layout, it just makes a layout based on the topology. Sometimes you can affect the layout by changing the order in which you create nodes, though. Right now, the layout flops around wildly whenever I add/remove a path, so I probably won't try to tweak the layout until we've thought more about the relationships. > > There is actually one is-a relationship which you are showing as > "makes-a" instead: the link from HTML::Mason::Request::ApacheHandler to > HTML::Mason::Request. Yeah, I thought about that - the :Request::ApacheHandler class actually does make a :Request (by calling $self->SUPER::new), but perhaps it's a bit disingenuous to call that a 'makes-a' relationship. After all, I don't do that with the Component classes, I just lump subclasses into one node. > The ApacheHandler stuff seems to be one of the less pluggable areas to > me. One thing I've done recently in this area is to make the :ApacheHandler a mod_perl method handler, in order to facilitate subclassing. But you're right, the :ApacheHandler relationships may be a bit muddled at the moment. -Ken |