Re: [Makumba-user] [Makumba-devel] [ITD/mak] New makumba feature - search forms

[Rudolf M. <rud...@st...>]

hey!

thanks for your thoughts gwen!

Gwenael Alizon wrote:
> [Rudi]
>> *** <mak:searchForm in="test.Person" labelName="p" ..
>> and if the labelName = is not specified, 'o' will be used as default.
>>
>> *** <mak:searchForm in="test.Person p" ...
>> i.e. to specify the label name in the form. that is however against the
>> usage we have now for forms.
> 
> I do not think that the "o" label as default is any natural for the
> mak:user (I would think you needed to pick up a letter when
> developing?). I would rather not propose any default and enforce the
> definition of this label in the searchForm.
> Now I have no preference yet between having labeName as mandatory
> attribute or requiring a label after "test.Person".
> 
> If you say that "test.Person p" is not have we use the form now, then
> just fine we can IMHO have an additional attribute "labelName".
> The only advantage of "test.Person p" is that it is a label definition
> that is used everywhere else already. But as said I do not see an
> issue changing this for mak:searchForms.


maybe the most logical thing to use would be object="...", as we do for 
editForm.. ?

> Maybe if we ever want to support searches accross several objects
> (although I cannot really think of a any practical usage of it right
> now), it will then be needed to have the labels defined as
> in="test.Company c, test.Person p" and the criterion as <mak:criterion
> fields="c.name, p.name, p.surname">... but.
> 1/ I can think this would be quite an overhead to support this and
> this is probably not needed very often
> 2/ my feeling is that if such searches are needed it is that the MDD
> has been poorly defined and that the search should have been made over
> a "parent" MDD that would contain a pointer to company and person (in
> this example).


i thought a lot about this too, and i did not find any example where you 
need to search across unrelated forms. the only thing we came up was 
when you implement a generic / PA wide search that would search in 
emails, archives, ...

> That's it for now for the design.
> Testing a little I have still a couple of implementation remarks:
> http://tequila.best.eu.org/rudi-k/games/search.jspx#22
> -> shouldn't 'role="rangeBegin"' be requested if rangeEnd is used as well?


i think at the moment the rangeBegin is kind of automated. do you think 
we should enforce marking it?

> -> It seems that if there is no results the page breaks (left menu and
> footer not displayed):
> try with time input (sorry criterion :)) between 80 and 100


there was an error with the pagination. fixed now (though the 
pagintation is still not totally perfect :-) )

greetings
rudi