[Madwifi-devel] bugfix in power save support for AP mode (BSD branch)
Status: Beta
Brought to you by:
otaku
From: Mindaugas <min...@ba...> - 2005-03-23 16:24:40
|
there are bug in _IEEE80211_NODE_SAVEQ_ENQUEUE macro - it increments savedq.qlen after calling skb_queue_tail, thus we get double incrementing and prevents from tim update in ieee80211_pwrsave() function. my fix : RCS file: /cvsroot/madwifi/madwifi/net80211/ieee80211_linux.h,v retrieving revision 1.5.2.5 diff -u -r1.5.2.5 ieee80211_linux.h --- ieee80211_linux.h 20 Mar 2005 01:53:02 -0000 1.5.2.5 +++ ieee80211_linux.h 23 Mar 2005 15:36:14 -0000 @@ -129,7 +129,9 @@ skb_queue_tail(&(_ni)->ni_savedq, (_skb)); \ (_age) -= M_AGE_GET(&(_ni)->ni_savedq.next); \ M_AGE_SET((_skb), (_age)); \ - (_qlen) = ++((_ni)->ni_savedq.qlen); \ + (_qlen) = ((_ni)->ni_savedq.qlen); \ + /*minde: qlen alredy increased in skb_queue_tail \ + (_qlen) = ++((_ni)->ni_savedq.qlen); */ \ } while (0) // TODO: check NODE_SAVEQ_ENQUEUE regarding age |