Re: [Madwifi-devel] [PATCH] help kudzu configure 'ath0' correctly on fedora

[Satish B. <ba...@fa...>]

On Sun, 14 Nov 2004, Sam Leffler wrote:

> On Saturday 13 November 2004 11:09 pm, Satish Balay wrote:
> > I had posted this ealier on madwifi-users list (reposting
> > appropriately on madwifi-devel list)
> >
> > The attach patch (1 line addtion) - enables 'kudzu' hardware detection
> > tool to detect that madwifi uses 'ath' naming scheme (ath0) - instead
> > of the default 'eth' naming scheme.
> >
> > I've tested this with madwifi-cvs-2004-11-11.tar.bz2 on FedoraCore 3
> > (the patched driver is working for the past 24 hours). With this patch
> > - kudzu addes 'alias ath0 ath_pci' /etc/modprobe.conf (instead of the
> > incorrect 'alias eth1 ath_pci)
> 
> pci_name doesn't exist on a 2.4.20-8 kernel I have. 

ChangeLog-2.4.22:  o pci_name()

> Not sure if it matters but it would be helpful if you could either
> provide a more portable patch or quantify the kernel versions where
> this change is relevant.

Looks like - all 2.6 kernels & all 2.4 >= 2.4.22 have pci_name(). I'm
guessing the following check should be sufficient.

#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,4,22)

> FWIW it appears to apply cleanly on 2.4.26 and all 2.6 kernels but
> it didn't have any noticeable affect for kudzu on my RH9+2.6.9 test
> system.

Looking at 'bk' kernel sources - this patch has a timestamp of
July-2003 (not sure when it actually got into 2.4/26 kernel trees)

RH9 was released in March-2003? - well before this feature was added
into kernel-2.6/2.4 - so RHL9's kudzu - I guess - wasn't using this
feature.

I've tested it on FC3 - which has kudzu-1.1.95-1/kernel-2.6.9 - and it
appears to make a difference.

The modified patch is attached. (and it works for me)

Satish

PS: looking for other drivers that do this in 2.6.9 kernel source - I
get the following list:

% find drivers -type f -name "*.c" -exec grep -H pci_name {} \; |grep bus_info |egrep str[n]*cpy | cut -d ':' -f 1 | sort | uniq | xargs grep -l GDRVINFO
drivers/net/amd8111e.c
drivers/net/dl2k.c
drivers/net/eepro100.c
drivers/net/forcedeth.c
drivers/net/hamachi.c
drivers/net/ixgb/ixgb_ethtool.c
drivers/net/natsemi.c
drivers/net/ns83820.c
drivers/net/sundance.c
drivers/net/tulip/tulip_core.c
drivers/net/tulip/xircom_tulip_cb.c
drivers/net/typhoon.c
drivers/net/yellowfin.c