Re: [Madwifi-devel] A driver porting patch for the release 0.9.4 to work with the new kernel networking API changes.

[Pavel R. <pr...@gn...>]

On Thu, 2009-08-06 at 16:40 +0300, Amr Ali wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> I've downloaded today the latest release for madwifi-0.9.4 and saw that
> it won't compile under my 2.6.30 vanilla kernel, and after investigating
> the issue, I figured out that the driver(s) were using the old kernel
> networking API. So I've decided to port them to the new kernel API,
> which I did and you will find the patch in the attachment and a link in
> pastebin.com for it as well.

This is already fixed in the 0.9.4 branch.

> +#include <linux/pci.h>

This is already included through if_ath_pci.h when compiling for PCI
bus.

> +#include <linux/netdevice.h>

This is already included a few lines lower.

> -#if !defined(IRQ_NONE)
> +#if defined(IRQ_NONE)
>  typedef void irqreturn_t;
>  #define        IRQ_NONE

That's wrong.  It would break older kernels.

> --- madwifi-0.9.4/ath_rate/minstrel/modules.order       1970-01-01 02:00:00.000000000 +0200
> +++ madwifi-0.9.4-patched/ath_rate/minstrel/modules.order       2009-08-06 12:23:14.000000000 +0300

Please don't include diffs for the files that are not distributed.
Also, please look at your changes to make sure that they only include
the changes made by you intentionally.

-- 
Regards,
Pavel Roskin