Re: [Madwifi-users] [PATCH 2/5] madwifi: Fix format strings warnings for x86_64.
Status: Beta
Brought to you by:
otaku
From: Michael R. <ma...@no...> - 2005-10-18 07:45:03
|
Hi. Pavel Roskin wrote: >>The problem was not the kernel version it was the gcc version. > I don't see how you can make that conclusion. I remember a similar situation. Atheros makes use of 'z' in their new code as well, and compiling that with GCC 2.95 resulted in warnings. But you're right that such warnings could be safely ignored. > Backward compatibility is often overrated. When I dropped support for > 2.4 kernels between two release candidates of the Orinoco driver, not a > single person complained. Yet I'm constantly getting requests to add > support for Agere firmware download. Users often want to upgrade > whatever it takes to get support for their hardware. > > I don't know, maybe madwifi is catering to a more conservative audience, > but it's strange, considering that it serves newer hardware. It seems that some embedded board vendors still deliver rather old 2.4.x kernel versions, and for some of them Madwifi is needed. Personally, I'm still sticking with 2.4.2[68] on some production systems, simply out of the "never change a running system" idea. So, when it comes to a "new feature vs. backward compatibility" situation and as long as it doesn't really hurt, I'd vote for backward compatibility. In this case I'd say that casting to int rather than making use of 'z' should be the way to go. It is backward compatible, and it helps avoid warning messages. Bye, Mike -- Sign EDRI petition against data retention: http://www.dataretentionisnosolution.com Use PGP/GPG! My key: http://keys.indymedia.org/cgi-bin/lookup?op=get&search=62C29B94 Fingerprint: BC2E 79BF 0C8F 0282 864B 9CEC 8343 5169 62C2 9B94 |