[Madwifi-devel] Updating HAL
Status: Beta
Brought to you by:
otaku
From: Pavel R. <pr...@gn...> - 2007-03-24 02:50:44
|
Hello, Scott! I think if we are going to have a new HAL in the next release it's time to act now. It's not a change that could be made late in the development cycle. Perhaps it would be better not go directly to the latest HAL (0.9.30.97), but go through the intermediate version 0.9.20.3. It's important so that we don't combine to many changes at once. I would be useful to be able to go through the historic versions to trace possible breakage. The diff between the trunk and madwifi-hal-0.9.20.3 is quite large, even without the gratuitous ID changes. I think all those IDs could be removed, but it's a topic for a separate discussion. I could reduce some trivial differences. Now I'm trying to integrate some bigger changes. I tried to merge the changes to the tx_complete arguments, but it looks like something may be wrong there. The original code was passing ds (if_ath.c:7285), which was the last descriptor in the buffer (if_ath.c:7208). The new code passes bf instead. amrr.c and onoe.c don't need ds since they use the new shared stats for the buffer. But sample.c actually uses the descriptor to extract some statistic, and it's using the first descriptor now rather than the last (sample.c:662). Could you please check if this is correct? Are you porting the changes from FreeBSD? Could you please tell me where exactly you are taking the changes from, so I could have another reference? -- Regards, Pavel Roskin |