Re: [Madwifi-devel] [PATCH] enable softled on HP laptops

[Pavel R. <pr...@gn...>]

Hello Helge,

I'm not sure why you send a personal copy to me, but anyway.

On Mon, 2006-10-30 at 21:32 +0100, Helge Deller wrote:
> -	sc->sc_softled = (devid == AR5212_DEVID_IBM || devid == AR5211_DEVID);
> +	if (devid == AR5212_DEVID_IBM || devid == AR5211_DEVID)
> +		sc->sc_softled = 1;

What's the purpose of this part?  I think it makes no difference.
sc->sc_softled is initialized with 0 and it's never assigned any other
value before that point, so it would be 0 even the new value is not
assigned.

-- 
Regards,
Pavel Roskin