From: Giuseppe P. <gi...@gm...> - 2012-07-29 15:26:29
|
Hi, I completed the improvement of the panel applet "keyboard layout switcher". You can see a snapshot of the final version here: http://postimage.org/image/jx2nu2yip/ The features are: - change keyboard model clicking on button and choosing from a list - add / remove keyboard layouts choosing from a complete list including the variants - move the existing layouts up and down so changing the toggling sequence and the default (first) layout - change layout toggle/switch option clicking on button and choosing from a list The source code is here http://code.google.com/p/giuspen-lxpanel-0-5-10/source/checkout I started my work cloning the 0.5.10 version of lxpanel, the only changes that I made are to lxpanel-0.5.10/src/plugins/xkb/* As you can see from the screenshot, not all the flags are available. The flags are in lxpanel-0.5.10/src/plugins/xkb/flags/*.svg and are taken from xfce4-xkb-plugin. If anybody would like to help me complete the missing (svg) flags please contact me. I would be very glad if my work will be accepted in the lxpanel main branch. Cheers, Giuseppe. |
From: Giuseppe P. <gi...@gm...> - 2012-07-30 09:52:39
|
updates on the keyboard layouts handler panel applet: - fixed bugs - added flags (only two flags are missing now) please let me know if you will include my job in the lxpanel main branch or not regards, Giuseppe. On Sun, Jul 29, 2012 at 5:26 PM, Giuseppe Penone <gi...@gm...> wrote: > Hi, > I completed the improvement of the panel applet "keyboard layout switcher". > You can see a snapshot of the final version here: > http://postimage.org/image/jx2nu2yip/ > > The features are: > - change keyboard model clicking on button and choosing from a list > - add / remove keyboard layouts choosing from a complete list including > the variants > - move the existing layouts up and down so changing the toggling sequence > and the default (first) layout > - change layout toggle/switch option clicking on button and choosing from > a list > > The source code is here > http://code.google.com/p/giuspen-lxpanel-0-5-10/source/checkout > > I started my work cloning the 0.5.10 version of lxpanel, the only changes > that I made are to > lxpanel-0.5.10/src/plugins/xkb/* > > As you can see from the screenshot, not all the flags are available. > The flags are in lxpanel-0.5.10/src/plugins/xkb/flags/*.svg and are taken > from xfce4-xkb-plugin. > If anybody would like to help me complete the missing (svg) flags please > contact me. > > I would be very glad if my work will be accepted in the lxpanel main > branch. > Cheers, > Giuseppe. > > > > |
From: Giuseppe P. <gi...@gm...> - 2012-07-30 12:14:14
|
for whou would like to quick test the keyboard layouts handler applet on lubuntu 12.04 I created debian packages http://www.giuspen.com/software/lxpanel_0.5.10-1_amd64.deb http://www.giuspen.com/software/lxpanel_0.5.10-1_i386.deb just install and run "lxpanelctl restart" Cheers, Giuseppe. On Mon, Jul 30, 2012 at 11:52 AM, Giuseppe Penone <gi...@gm...> wrote: > updates on the keyboard layouts handler panel applet: > > - fixed bugs > - added flags (only two flags are missing now) > > please let me know if you will include my job in the lxpanel main branch > or not > > regards, > Giuseppe. > > > > > On Sun, Jul 29, 2012 at 5:26 PM, Giuseppe Penone <gi...@gm...>wrote: > >> Hi, >> I completed the improvement of the panel applet "keyboard layout >> switcher". >> You can see a snapshot of the final version here: >> http://postimage.org/image/jx2nu2yip/ >> >> The features are: >> - change keyboard model clicking on button and choosing from a list >> - add / remove keyboard layouts choosing from a complete list including >> the variants >> - move the existing layouts up and down so changing the toggling sequence >> and the default (first) layout >> - change layout toggle/switch option clicking on button and choosing from >> a list >> >> The source code is here >> http://code.google.com/p/giuspen-lxpanel-0-5-10/source/checkout >> >> I started my work cloning the 0.5.10 version of lxpanel, the only changes >> that I made are to >> lxpanel-0.5.10/src/plugins/xkb/* >> >> As you can see from the screenshot, not all the flags are available. >> The flags are in lxpanel-0.5.10/src/plugins/xkb/flags/*.svg and are taken >> from xfce4-xkb-plugin. >> If anybody would like to help me complete the missing (svg) flags please >> contact me. >> >> I would be very glad if my work will be accepted in the lxpanel main >> branch. >> Cheers, >> Giuseppe. >> >> >> >> > |
From: Henry G. <hsg...@go...> - 2012-08-01 10:57:26
|
Hi Giuseppe, Nice work! I haven't looked at the code in much detail yet, but here are some random comments: - The "Select Keyboard Model" window is unsorted, which makes it hard to search. - I cannot find my currently listed Keyboard Model, "evdev". Should it be in that list? - The German and US flags seem to have different sizes. Is that on purpose? - When using text layout, and putting the mouse over the plugin, the background becomes almost white, with white letters. This is very difficult to read. (I guess this was already the case with the old plugin?) Some more: On Sun, Jul 29, 2012 at 05:26:23PM +0200, Giuseppe Penone wrote: > The source code is here > http://code.google.com/p/giuspen-lxpanel-0-5-10/source/checkout > > I started my work cloning the 0.5.10 version of lxpanel, A patch to the git repository [1] would be easier to handle, since all the files added by the autotools generate a lot of noise. But it is ok for now. > the only changes that I made are to lxpanel-0.5.10/src/plugins/xkb/* Actually, I saw a change outside that directory, too. Would be great if you could point out if there are more. > ... > The flags are in lxpanel-0.5.10/src/plugins/xkb/flags/*.svg and are taken > from xfce4-xkb-plugin. Should give them proper credit in the AUTHORS file. I assume the license is ok? Cheers, Henry [1] git://lxde.git.sourceforge.net/gitroot/lxde/lxpanel |
From: PCMan <pcm...@gm...> - 2012-08-01 11:51:01
|
On Wed, Aug 1, 2012 at 6:56 PM, Henry Gebhardt <hsg...@go...> wrote: > Hi Giuseppe, > > Nice work! > > I haven't looked at the code in much detail yet, but here are some > random comments: > > - The "Select Keyboard Model" window is unsorted, which makes it > hard to search. > > - I cannot find my currently listed Keyboard Model, "evdev". Should > it be in that list? > > - The German and US flags seem to have different sizes. Is that on > purpose? > > - When using text layout, and putting the mouse over the plugin, the > background becomes almost white, with white letters. This is very > difficult to read. (I guess this was already the case with the old > plugin?) > > Some more: > > On Sun, Jul 29, 2012 at 05:26:23PM +0200, Giuseppe Penone wrote: >> The source code is here >> http://code.google.com/p/giuspen-lxpanel-0-5-10/source/checkout >> >> I started my work cloning the 0.5.10 version of lxpanel, > > A patch to the git repository [1] would be easier to handle, since all > the files added by the autotools generate a lot of noise. But it is ok > for now. > >> the only changes that I made are to lxpanel-0.5.10/src/plugins/xkb/* > > Actually, I saw a change outside that directory, too. Would be great if > you could point out if there are more. > >> ... >> The flags are in lxpanel-0.5.10/src/plugins/xkb/flags/*.svg and are taken >> from xfce4-xkb-plugin. > > Should give them proper credit in the AUTHORS file. I assume the license > is ok? > > Cheers, > > Henry > > [1] git://lxde.git.sourceforge.net/gitroot/lxde/lxpanel > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > Lxde-list mailing list > Lxd...@li... > https://lists.sourceforge.net/lists/listinfo/lxde-list Thanks for the great work! Has anyone tried this so far? I speak Chinese and I do not know well how a good keyboard layout tool should behave. I'll try to install this one tomorrow after I get home, though. If no serioud problems are found, I think merging the changes back to lxpanel trunk is ok. Cheers! |
From: Henry G. <hsg...@go...> - 2012-08-10 19:48:27
|
Hi guys, On Thu, Aug 09, 2012 at 08:53:18PM +0200, Giuseppe Penone wrote: > Hi Julien, > what you mean with "when the flag image is OK"? > > actually with 1 -> 5 you are scaling the flag *0.5 -> *0.9 after the > lxpanel icons side decide by the user. > I understand you would like to have a position 6 where the flag has the > same size as defined on the > panel icons size, I'll do it as soon as I'll have a couple of hours. You could also query the exact scale factor with a spin button. > ... > > On Thu, Aug 9, 2012 at 12:01 AM, Julien Lavergne <gi...@ub...> wrote: > > I pushed version 5 to trunk to get more testing. Hm, it seems there are differences to the current version 5. Just to clarify, Giuseppe, did you accidentally overwrite your version 5 with what should be 6? I have a few small comments about the code, version 0.5.10.5 on your website. The numbers after the filename are line numbers. xkb.h: No need to #include "ev.h" anymore. xkb-plugin.c:269: There already is a variable called "fp" in this function. I would prefer not to override that definition. xkb-plugin.c:544,646,848: Do trampolines work everywhere we care? The gcc(1) manpage says: > A trampoline is a small piece of data or code that is created at run > time on the stack when the address of a nested function is taken, and > is used to call the nested function indirectly. For some targets, it > is made up of data only and thus requires no special treatment. But, > for most targets, it is made up of code and thus requires the stack to > be made executable in order for the program to work properly. Sofar xkb is the only plugin that requires an executable stack (see execstack(8)). Ubuntu seems to prefer avoiding it: https://wiki.ubuntu.com/SecurityTeam/Roadmap/ExecutableStacks and I don't think the C standard allows them. Opinions? xkb-plugin.c:926-928: If the system() calls fail, an ERR("xkb: blah, blah failed\n"); message should be returned. And perhaps replace the g_printf() with LOG(LOG_INFO, "xkb: blah, blah %s\n", str); to be consistent. xkb-plugin.c: Instead of 5 times on_radiobutton_flag_size_5_toggled() you could pass the flag_size in the p_data, preferably using GINT_TO_POINTER() and GPOINTER_TO_INT(), see http://developer.gnome.org/glib/2.32/glib-Type-Conversion-Macros.html But I am nitpicking. :) xkb-plugin.c:478:13: warning: 'on_hscale_flag_size_value_changed' defined but not used [-Wunused-function] Black text on dark background doesn't work too well. It would be nice to have that configurable. (Or is there a better way?) And one bug: The plugin correctly identifies my keyboard layout as "de", but until it is configured the config dialog only shows "us" in the "Keyboard Layouts" section. Thanks for the great work! It looks really awesome! Regards, Henry |
From: Giuseppe P. <gi...@gm...> - 2012-08-01 12:28:39
|
Hi Henry - The "Select Keyboard Model" window is unsorted, which makes it > hard to search. > I'll fix this > > - I cannot find my currently listed Keyboard Model, "evdev". Should > it be in that list? > The list of keyboard models, keyboard layouts+variants and keyboard shortcuts to change layout are imported statically from xkeyboard-config. xkeyboard-config lists all the options to be feeded to *setxkbmap *(which is the only dependency) If you feel that an option is missing try it and then provide me neme (e.g. evdev) and description and I'll add it to the list. > > - The German and US flags seem to have different sizes. Is that on > purpose? > I'll fix this. - When using text layout, and putting the mouse over the plugin, the > background becomes almost white, with white letters. This is very > difficult to read. (I guess this was already the case with the old > plugin?) > Yes I didn't change anything of this, but I'll try to reproduce the problem as it never happened on my lubuntu 12.04. A patch to the git repository [1] would be easier to handle, since all > the files added by the autotools generate a lot of noise. But it is ok > for now. > > > the only changes that I made are to lxpanel-0.5.10/src/plugins/xkb/* > > Actually, I saw a change outside that directory, too. Would be great if > you could point out if there are more. > with meld (http://meldmerge.org/) you can easily spot the differences between the two *lxpanel-0.5.10/src/plugins/xkb/** forget about the other changes you see that are from the ubuntu patch, the only one that I added is this in *lxpanel-0.5.10/configure.ac* @@ -40,6 +40,7 @@ pkg_modules="$pkg_modules \ gio-unix-2.0 \ gthread-2.0 \ + alsa \ libmenu-cache" # libstartup-notification-1.0" PKG_CHECK_MODULES(PACKAGE, [$pkg_modules]) I believe that alsa should be added to the dependencies since the plugin volume works bad and requires to load manually a kernel module, volumealsa instead works good but is built only if the header files are found (libasound2-dev on lubuntu) > The flags are in lxpanel-0.5.10/src/plugins/xkb/flags/*.svg and are taken > > from xfce4-xkb-plugin. > > Should give them proper credit in the AUTHORS file. I assume the license > is ok? > The first svg flags are from the flags folder of xfce4-xkb-plugin which are GPL, xfce4-xkb-plugin is anyway already credited since the original "keyboard layout switcher" comes from that Other flags are taken from http://hewgill.com/flags/ or https://github.com/koppi/iso-country-flags-svg-collection/tree/master/svg/country-4x3or wikipedia, they should probably be credited as well. I will write again when I'll have the reported issues fixed. Regards, Giuseppe. |
From: Giuseppe P. <gi...@gm...> - 2012-08-01 22:49:13
|
Hi, I implemented all the changes requested from Henry and Ikem in the previous mails. You can pick the code from http://code.google.com/p/giuspen-lxpanel-0-5-10/source/checkout or wait for tomorrow (Italian time) when I'll create source code archive and debian packages and provide the links here. Cheers, Giuseppe. On Wed, Aug 1, 2012 at 3:19 PM, Giuseppe Penone <gi...@gm...> wrote: > ok I'll do these changes and write here when it's done. > > > > On Wed, Aug 1, 2012 at 3:04 PM, Ikem Krueger <ike...@go...>wrote: > >> >> 2012/8/1 Giuseppe Penone <gi...@gm...>: >> >> > Tell me, if I'm able I will improve... >> >> The flags using the whole space of the panel in height, meanwhile all >> the other icons are smaller. I like to see them using the default icon >> size. >> >> When I right click on the panel item it says "Keyboard Layouts >> Handler". I suggest to change that to "Keyboard Layout Handler" as it >> is called in the window title. >> >> I like to see the button size/order of "Add" "Remove" "Up" "Down" >> changed to that of "Add / Remove Panel Items". >> >> -- >> My blog: http://linux-workers.posterous.com/ >> > > |
From: Giuseppe P. <gi...@gm...> - 2012-08-02 09:24:49
|
Hi, you can find screenshots, source code archive and debian packages of the latest version of the keyboard layout handler here: http://www.giuspen.com/customs Regards, Giuseppe. On Thu, Aug 2, 2012 at 12:49 AM, Giuseppe Penone <gi...@gm...> wrote: > Hi, I implemented all the changes requested from Henry and Ikem in the > previous mails. > > You can pick the code from > http://code.google.com/p/giuspen-lxpanel-0-5-10/source/checkout > or wait for tomorrow (Italian time) when I'll create source code archive > and debian packages > and provide the links here. > > Cheers, > Giuseppe. > |
From: Stephen S. <eco...@fa...> - 2012-08-02 09:33:01
|
Hi Giuseppe, well done! I just want suggest you to follow some Gnome/Gtk HIG, as far as i know, the GtkFrame widget is no longer used to separate sections, instead, you may use the labels (with bold markup) as separators. See here http://developer.gnome.org/hig-book/3.4/design-window.html.en (the 8.2.2 Dialogs section, which is pretty much your case). Saluti, Stephen Smally Il 02/08/2012 11:24, Giuseppe Penone ha scritto: > Hi, you can find screenshots, source code archive and debian packages of > the latest version of the keyboard layout handler here: > http://www.giuspen.com/customs > Regards, > Giuseppe. > > > On Thu, Aug 2, 2012 at 12:49 AM, Giuseppe Penone <gi...@gm... > <mailto:gi...@gm...>> wrote: > > Hi, I implemented all the changes requested from Henry and Ikem in > the previous mails. > > You can pick the code from > http://code.google.com/p/giuspen-lxpanel-0-5-10/source/checkout > or wait for tomorrow (Italian time) when I'll create source code > archive and debian packages > and provide the links here. > > Cheers, > Giuseppe. > > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > > > > _______________________________________________ > Lxde-list mailing list > Lxd...@li... > https://lists.sourceforge.net/lists/listinfo/lxde-list > |
From: Giuseppe P. <gi...@gm...> - 2012-08-02 19:15:01
|
Hi, I made as you and gnome HIG suggest, thanks for the tip. Ciao, Giuseppe. On Thu, Aug 2, 2012 at 11:32 AM, Stephen Smally <eco...@fa...>wrote: > Hi Giuseppe, well done! > I just want suggest you to follow some Gnome/Gtk HIG, as far as i know, > the GtkFrame widget is no longer used to separate sections, instead, you > may use the labels (with bold markup) as separators. See here > http://developer.gnome.org/hig-book/3.4/design-window.html.en (the 8.2.2 > Dialogs section, which is pretty much your case). > > Saluti, > Stephen Smally > > Il 02/08/2012 11:24, Giuseppe Penone ha scritto: > > Hi, you can find screenshots, source code archive and debian packages of > > the latest version of the keyboard layout handler here: > > http://www.giuspen.com/customs > > Regards, > > Giuseppe. > > > > > > On Thu, Aug 2, 2012 at 12:49 AM, Giuseppe Penone <gi...@gm... > > <mailto:gi...@gm...>> wrote: > > > > Hi, I implemented all the changes requested from Henry and Ikem in > > the previous mails. > > > > You can pick the code from > > http://code.google.com/p/giuspen-lxpanel-0-5-10/source/checkout > > or wait for tomorrow (Italian time) when I'll create source code > > archive and debian packages > > and provide the links here. > > > > Cheers, > > Giuseppe. > > > > > > > > > ------------------------------------------------------------------------------ > > Live Security Virtual Conference > > Exclusive live event will cover all the ways today's security and > > threat landscape has changed and how IT managers can respond. Discussions > > will include endpoint security, mobile security and the latest in malware > > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > > > > > > > > _______________________________________________ > > Lxde-list mailing list > > Lxd...@li... > > https://lists.sourceforge.net/lists/listinfo/lxde-list > > > > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > Lxde-list mailing list > Lxd...@li... > https://lists.sourceforge.net/lists/listinfo/lxde-list > |
From: Giuseppe P. <gi...@gm...> - 2012-08-02 21:35:07
|
I released one more version here http://www.giuspen.com/customs (source code archive + debian packages) with gui changes that were to me requested to be more compliant with lxpanel. Please let me know if and when my work will be integrated in lxpanel main branch. Cheers, Giuseppe. On Thu, Aug 2, 2012 at 9:14 PM, Giuseppe Penone <gi...@gm...> wrote: > Hi, I made as you and gnome HIG suggest, thanks for the tip. > Ciao, > Giuseppe. > > > > On Thu, Aug 2, 2012 at 11:32 AM, Stephen Smally <eco...@fa...>wrote: > >> Hi Giuseppe, well done! >> I just want suggest you to follow some Gnome/Gtk HIG, as far as i know, >> the GtkFrame widget is no longer used to separate sections, instead, you >> may use the labels (with bold markup) as separators. See here >> http://developer.gnome.org/hig-book/3.4/design-window.html.en (the 8.2.2 >> Dialogs section, which is pretty much your case). >> >> Saluti, >> Stephen Smally >> >> Il 02/08/2012 11:24, Giuseppe Penone ha scritto: >> > Hi, you can find screenshots, source code archive and debian packages of >> > the latest version of the keyboard layout handler here: >> > http://www.giuspen.com/customs >> > Regards, >> > Giuseppe. >> > >> > >> > On Thu, Aug 2, 2012 at 12:49 AM, Giuseppe Penone <gi...@gm... >> > <mailto:gi...@gm...>> wrote: >> > >> > Hi, I implemented all the changes requested from Henry and Ikem in >> > the previous mails. >> > >> > You can pick the code from >> > http://code.google.com/p/giuspen-lxpanel-0-5-10/source/checkout >> > or wait for tomorrow (Italian time) when I'll create source code >> > archive and debian packages >> > and provide the links here. >> > >> > Cheers, >> > Giuseppe. >> > >> > >> > >> > >> ------------------------------------------------------------------------------ >> > Live Security Virtual Conference >> > Exclusive live event will cover all the ways today's security and >> > threat landscape has changed and how IT managers can respond. >> Discussions >> > will include endpoint security, mobile security and the latest in >> malware >> > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ >> > >> > >> > >> > _______________________________________________ >> > Lxde-list mailing list >> > Lxd...@li... >> > https://lists.sourceforge.net/lists/listinfo/lxde-list >> > >> >> >> >> ------------------------------------------------------------------------------ >> Live Security Virtual Conference >> Exclusive live event will cover all the ways today's security and >> threat landscape has changed and how IT managers can respond. Discussions >> will include endpoint security, mobile security and the latest in malware >> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ >> _______________________________________________ >> Lxde-list mailing list >> Lxd...@li... >> https://lists.sourceforge.net/lists/listinfo/lxde-list >> > > |
From: Stephen S. <eco...@fa...> - 2012-08-02 22:05:39
|
Other comments (hope you don't get bored ;-) ): * The Layouts TreeView would probably looks better when putted in a GtkFrame * Maybe is better to keep consistent with the other gnome/xfce tools and drop the flags images (using text only in the TreeView). * The Show Layout as should use a combobox, to be less cluttered * The Keyboard Model button may be on the same line of the label (pack_start the label and pack_end the button), and should be with no relief (gtk_button_set_relief (GTK_RELIEF_NONE)). Everything is IMHO, feel free to ignore me. Regards, Stephen Smally Il 02/08/2012 23:34, Giuseppe Penone ha scritto: > I released one more version here http://www.giuspen.com/customs (source > code archive + debian packages) > with gui changes that were to me requested to be more compliant with > lxpanel. > Please let me know if and when my work will be integrated in lxpanel > main branch. > Cheers, > Giuseppe. > > > > > On Thu, Aug 2, 2012 at 9:14 PM, Giuseppe Penone <gi...@gm... > <mailto:gi...@gm...>> wrote: > > Hi, I made as you and gnome HIG suggest, thanks for the tip. > Ciao, > Giuseppe. > > > > On Thu, Aug 2, 2012 at 11:32 AM, Stephen Smally > <eco...@fa... <mailto:eco...@fa...>> wrote: > > Hi Giuseppe, well done! > I just want suggest you to follow some Gnome/Gtk HIG, as far as > i know, > the GtkFrame widget is no longer used to separate sections, > instead, you > may use the labels (with bold markup) as separators. See here > http://developer.gnome.org/hig-book/3.4/design-window.html.en > (the 8.2.2 > Dialogs section, which is pretty much your case). > > Saluti, > Stephen Smally > > Il 02/08/2012 11:24, Giuseppe Penone ha scritto: > > Hi, you can find screenshots, source code archive and debian > packages of > > the latest version of the keyboard layout handler here: > > http://www.giuspen.com/customs > > Regards, > > Giuseppe. > > > > > > On Thu, Aug 2, 2012 at 12:49 AM, Giuseppe Penone > <gi...@gm... <mailto:gi...@gm...> > > <mailto:gi...@gm... <mailto:gi...@gm...>>> wrote: > > > > Hi, I implemented all the changes requested from Henry > and Ikem in > > the previous mails. > > > > You can pick the code from > > http://code.google.com/p/giuspen-lxpanel-0-5-10/source/checkout > > or wait for tomorrow (Italian time) when I'll create > source code > > archive and debian packages > > and provide the links here. > > > > Cheers, > > Giuseppe. > > > > > > > > > ------------------------------------------------------------------------------ > > Live Security Virtual Conference > > Exclusive live event will cover all the ways today's security and > > threat landscape has changed and how IT managers can respond. > Discussions > > will include endpoint security, mobile security and the > latest in malware > > threats. > http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > > > > > > > > _______________________________________________ > > Lxde-list mailing list > > Lxd...@li... > <mailto:Lxd...@li...> > > https://lists.sourceforge.net/lists/listinfo/lxde-list > > > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. > Discussions > will include endpoint security, mobile security and the latest > in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > Lxde-list mailing list > Lxd...@li... > <mailto:Lxd...@li...> > https://lists.sourceforge.net/lists/listinfo/lxde-list > > > > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > > > > _______________________________________________ > Lxde-list mailing list > Lxd...@li... > https://lists.sourceforge.net/lists/listinfo/lxde-list > |
From: Giuseppe P. <gi...@gm...> - 2012-08-03 10:00:20
|
Hi Stephen, * The Layouts TreeView would probably looks better when putted in a GtkFrame > I will try. > * Maybe is better to keep consistent with the other gnome/xfce tools and > drop the flags images (using text only in the TreeView). > I'm a real maniac about icons, I want icons in all menus if possible and in all lists because I find much faster to read icons than strings, so somebody have to patch my code before integrating in lxpanel I can't do this :) > * The Show Layout as should use a combobox, to be less cluttered > The bad in a combobox is that you cannot see all options at first glance. I think that when the options are few (only two in this case) the radiobutton is better. > * The Keyboard Model button may be on the same line of the label > (pack_start the label and pack_end the button), and should be with no > relief (gtk_button_set_relief (GTK_RELIEF_NONE)). > If the button has no relief the user could even not realize it's clickable, an exception is in the panel where everything is expected to be clickable. About buttons in line with the button I will try. Cheers, Giuseppe. |
From: Julien L. <gi...@ub...> - 2012-08-05 13:46:28
|
Le 08/01/2012 02:28 PM, Giuseppe Penone a écrit : > > > The flags are in lxpanel-0.5.10/src/plugins/xkb/flags/*.svg and > are taken > > from xfce4-xkb-plugin. > > Should give them proper credit in the AUTHORS file. I assume the > license > is ok? > > > The first svg flags are from the flags folder of xfce4-xkb-plugin > which are GPL, > xfce4-xkb-plugin is anyway already credited since the original > "keyboard layout switcher" > comes from that > > Other flags are taken from http://hewgill.com/flags/ or > https://github.com/koppi/iso-country-flags-svg-collection/tree/master/svg/country-4x3 > or wikipedia, > they should probably be credited as well. Something that could be very useful (at least for us in Lubuntu :-)), is an ability to specify our specific flags, to match the current theme (see https://wiki.ubuntu.com/Lubuntu/Artwork/Incoming/Precise/Ozone#Icons for an a example). For example, it could be achieve by providing a directory in /usr/share/lxpanel/profile/the_profil_name/ to override the flags by default. I will play with the applet today. If I don't see any problem, I'll merge it with trunk to get more testing. Regards, Julien Lavergne |
From: Giuseppe P. <gi...@gm...> - 2012-08-11 11:12:31
|
Hi, I will take care of your considerations as soon as possible, just wanted to ensure that I did not overwrite the source archive on my website. I downloaded it right now and compared with the versioned (and tagged 0.5, on branch xkb) version and noticed that there's just a problem: in the tarball two symbolic links in the flags folder were removed, weird. Probably the .tar.xz discards symbolic links. In case Julien got the code from version control, be careful that there's more than one branch. the branch named xkb includes a clean panel with only the xkb plugin modified (and the tagged releases), the default branch instead includes the integration between plugins launchbar and taskbar I'm working on. Cheers, Giuseppe. On Fri, Aug 10, 2012 at 10:47 PM, Henry Gebhardt <hsg...@go... > wrote: > Hi guys, > > On Thu, Aug 09, 2012 at 08:53:18PM +0200, Giuseppe Penone wrote: > > Hi Julien, > > what you mean with "when the flag image is OK"? > > > > actually with 1 -> 5 you are scaling the flag *0.5 -> *0.9 after the > > lxpanel icons side decide by the user. > > I understand you would like to have a position 6 where the flag has the > > same size as defined on the > > panel icons size, I'll do it as soon as I'll have a couple of hours. > > You could also query the exact scale factor with a spin button. > > > ... > > > > On Thu, Aug 9, 2012 at 12:01 AM, Julien Lavergne <gi...@ub...> > wrote: > > > I pushed version 5 to trunk to get more testing. > > Hm, it seems there are differences to the current version 5. Just to > clarify, Giuseppe, did you accidentally overwrite your version 5 with > what should be 6? > > > I have a few small comments about the code, version 0.5.10.5 on your > website. The numbers after the filename are line numbers. > > > xkb.h: No need to #include "ev.h" anymore. > > > xkb-plugin.c:269: There already is a variable called "fp" in this > function. I would prefer not to override that definition. > > > xkb-plugin.c:544,646,848: Do trampolines work everywhere we care? The > gcc(1) manpage says: > > > A trampoline is a small piece of data or code that is created at run > > time on the stack when the address of a nested function is taken, and > > is used to call the nested function indirectly. For some targets, it > > is made up of data only and thus requires no special treatment. But, > > for most targets, it is made up of code and thus requires the stack to > > be made executable in order for the program to work properly. > > Sofar xkb is the only plugin that requires an executable stack (see > execstack(8)). Ubuntu seems to prefer avoiding it: > https://wiki.ubuntu.com/SecurityTeam/Roadmap/ExecutableStacks > and I don't think the C standard allows them. Opinions? > > > xkb-plugin.c:926-928: If the system() calls fail, an > ERR("xkb: blah, blah failed\n"); > message should be returned. And perhaps replace the g_printf() with > LOG(LOG_INFO, "xkb: blah, blah %s\n", str); > to be consistent. > > > xkb-plugin.c: Instead of 5 times on_radiobutton_flag_size_5_toggled() > you could pass the flag_size in the p_data, preferably using > GINT_TO_POINTER() and GPOINTER_TO_INT(), see > http://developer.gnome.org/glib/2.32/glib-Type-Conversion-Macros.html > But I am nitpicking. :) > > > xkb-plugin.c:478:13: warning: 'on_hscale_flag_size_value_changed' > defined but not used [-Wunused-function] > > > Black text on dark background doesn't work too well. It would be nice to > have that configurable. (Or is there a better way?) > > > And one bug: The plugin correctly identifies my keyboard layout as "de", > but until it is configured the config dialog only shows "us" in the > "Keyboard Layouts" section. > > > Thanks for the great work! It looks really awesome! > > Regards, > Henry > |
From: Henry G. <hsg...@go...> - 2012-08-11 14:02:56
|
On Sat, Aug 11, 2012 at 02:12:24PM +0300, Giuseppe Penone wrote: > ... just wanted to ensure that I did not overwrite the source archive > on my website. Ah, I think I just got confused yesterday. All version 5 panels are the same indeed, and merged to master. Please disregard my comment. Sorry about that. Cheers, Henry |
From: Giuseppe P. <gi...@gm...> - 2012-08-12 17:40:14
|
Hi Henry, see my replies to your code review below: You could also query the exact scale factor with a spin button. > yes this would be simpler to implement and probably require less memory but it would be not fast and simple as the radiobuttons. for now I will go on with radiobuttons but if there will be the need for more sizes I will turn to a spinbutton. xkb.h: No need to #include "ev.h" anymore. > done. xkb-plugin.c:269: There already is a variable called "fp" in this > function. I would prefer not to override that definition. > done. xkb-plugin.c:544,646,848: Do trampolines work everywhere we care? The > gcc(1) manpage says: > > > A trampoline is a small piece of data or code that is created at run > > time on the stack when the address of a nested function is taken, and > > is used to call the nested function indirectly. For some targets, it > > is made up of data only and thus requires no special treatment. But, > > for most targets, it is made up of code and thus requires the stack to > > be made executable in order for the program to work properly. > > Sofar xkb is the only plugin that requires an executable stack (see > execstack(8)). Ubuntu seems to prefer avoiding it: > https://wiki.ubuntu.com/SecurityTeam/Roadmap/ExecutableStacks > and I don't think the C standard allows them. Opinions? > I was thinking defining a callback inside of a function was not any problem, my fault and inexperience, now I declared a single callback globally in place of the 3 nested ones, taking as data the pointer to the button that may need to be clicked. > xkb-plugin.c:926-928: If the system() calls fail, an > ERR("xkb: blah, blah failed\n"); > message should be returned. And perhaps replace the g_printf() with > LOG(LOG_INFO, "xkb: blah, blah %s\n", str); > to be consistent. > done. I didn't replace the g_print because it is commented and just for my first steps debug. xkb-plugin.c: Instead of 5 times on_radiobutton_flag_size_5_toggled() > you could pass the flag_size in the p_data, preferably using > GINT_TO_POINTER() and GPOINTER_TO_INT(), see > http://developer.gnome.org/glib/2.32/glib-Type-Conversion-Macros.html > But I am nitpicking. :) > this is unfortunately not possible because I need to give the pointer to the plugin in the data since that's not global, and there's no room for a second parameter. > xkb-plugin.c:478:13: warning: 'on_hscale_flag_size_value_changed' > defined but not used [-Wunused-function] > done. Black text on dark background doesn't work too well. It would be nice to > have that configurable. (Or is there a better way?) > now I set the color taking it from the panel text color, it should be fine. If you feel the need for custom colors anyway I can implement in future versions. > And one bug: The plugin correctly identifies my keyboard layout as "de", > but until it is configured the config dialog only shows "us" in the > "Keyboard Layouts" section. > It's not clear to me, you say that the plugin identifies the keyboard layout but then it shows "us". Maybe you mean that on the panel you have the correct indication "DE" but the configuration dialog shows "US"? If you can reproduce the problem, can you send me the output of "setxkbmap -query" either before and after changing the configuration through the plugin? Many thanks for the useful code review, I really appreciated. For the latest dev code instructions on http://www.giuspen.com/customs/#dev including cloning and moving to the correct branch Cheers, Giuseppe. |
From: Henry G. <hsg...@go...> - 2012-08-13 19:39:59
|
Hi Giuseppe, On Sun, Aug 12, 2012 at 08:40:05PM +0300, Giuseppe Penone wrote: > > You could also query the exact scale factor with a spin button. > > yes this would be simpler to implement and probably require less memory > but it would be not fast and simple as the radiobuttons. > for now I will go on with radiobuttons but if there will be the need > for more sizes I will turn to a spinbutton. ok, makes sense. > ... > > xkb-plugin.c: Instead of 5 times on_radiobutton_flag_size_5_toggled() > > you could pass the flag_size in the p_data, preferably using > > GINT_TO_POINTER() and GPOINTER_TO_INT(), see > > http://developer.gnome.org/glib/2.32/glib-Type-Conversion-Macros.html > > But I am nitpicking. :) > > this is unfortunately not possible because I need to give the pointer > to the plugin in the data since that's not global, and there's no room > for a second parameter. Eh, don't know how I could have missed that. :) > ... > > Black text on dark background doesn't work too well. It would be nice to > > have that configurable. (Or is there a better way?) > > > > now I set the color taking it from the panel text color, it should be fine. > If you feel the need for custom colors anyway I can implement in future > versions. Thanks, I will test it when I have a bit more time. > > > And one bug: The plugin correctly identifies my keyboard layout as "de", > > but until it is configured the config dialog only shows "us" in the > > "Keyboard Layouts" section. > > > > It's not clear to me, you say that the plugin identifies the keyboard > layout but then it shows "us". > Maybe you mean that on the panel you have the correct indication "DE" > but the configuration dialog shows "US"? Yes! > If you can reproduce the problem, can you send me the output of > "setxkbmap -query" either before and after changing the configuration > through the plugin? Maybe this is a setxkbmap problem? Steps to reproduce: a. Remove the xkb plugin. Not sure if this is sufficient. Then: $ setxkbmap -query rules: evdev model: evdev layout: us But this is wrong. I definitely have a "de" layout set, with umlaut and everything working. b. Add the xkb plugin. In the panel it shows the German flag, but in the config the list of layouts only includes "us". setxkbmap -query is the same as above. Also, did you see bug ID 3556371, url here[1]? I have no opinion on it, but wanted to make you aware of it. Thanks! Henry [1] https://sourceforge.net/tracker/?func=detail&atid=894869&aid=3556371&group_id=180858 |
From: Giuseppe P. <gi...@gm...> - 2012-08-13 20:25:02
|
Hi Henry, > If you can reproduce the problem, can you send me the output of > > "setxkbmap -query" either before and after changing the configuration > > through the plugin? > > Maybe this is a setxkbmap problem? > > Steps to reproduce: > > a. Remove the xkb plugin. Not sure if this is sufficient. Then: > > $ setxkbmap -query > rules: evdev > model: evdev > layout: us > > But this is wrong. I definitely have a "de" layout set, with umlaut and > everything working. > > b. Add the xkb plugin. In the panel it shows the German flag, but in the > config the list of layouts only includes "us". setxkbmap -query is the > same as above. > It seems that "setxkbmap -query" does not work well unfortunately, I will fix this. Also, did you see bug ID 3556371, url here[1]? I have no opinion on it, > but wanted to make you aware of it. > [1] > https://sourceforge.net/tracker/?func=detail&atid=894869&aid=3556371&group_id=180858 > This is my fault. For me and other users of the old plugin, this functionality to go back to the default layout for every opened window was simply irritating so I didn't propose it in the new version, wanted to see if somebody really found it useful and the answer is: yes, somebody needs it :) I will add it again, but being disabled by default. Thank you, cheers, Giuseppe. |
From: Giuseppe P. <gi...@gm...> - 2012-08-05 15:10:12
|
Hi Julien, the flags that I found at https://wiki.ubuntu.com/Lubuntu/Artwork/Incoming/Precise/Ozone?action=AttachFile&do=view&target=lubuntu-lxpanel-flags.tar.gz are not really flags but merely text in png. If you consider important to add the support for them anyway I'll add them as a third option (image, text label, text png), let me know. Cheers, Giuseppe. On Sun, Aug 5, 2012 at 3:46 PM, Julien Lavergne <gi...@ub...> wrote: > Le 08/01/2012 02:28 PM, Giuseppe Penone a écrit : > > > > The flags are in lxpanel-0.5.10/src/plugins/xkb/flags/*.svg and are >> taken >> > from xfce4-xkb-plugin. >> >> Should give them proper credit in the AUTHORS file. I assume the license >> is ok? >> > > The first svg flags are from the flags folder of xfce4-xkb-plugin which > are GPL, > xfce4-xkb-plugin is anyway already credited since the original "keyboard > layout switcher" > comes from that > > Other flags are taken from http://hewgill.com/flags/ or > https://github.com/koppi/iso-country-flags-svg-collection/tree/master/svg/country-4x3or wikipedia, > they should probably be credited as well. > > Something that could be very useful (at least for us in Lubuntu :-)), is > an ability to specify our specific flags, to match the current theme (see > https://wiki.ubuntu.com/Lubuntu/Artwork/Incoming/Precise/Ozone#Icons for > an a example). For example, it could be achieve by providing a directory in > /usr/share/lxpanel/profile/the_profil_name/ to override the flags by > default. > > I will play with the applet today. If I don't see any problem, I'll merge > it with trunk to get more testing. > > Regards, > Julien Lavergne > |
From: Julien L. <gi...@ub...> - 2012-08-05 21:48:09
|
Le 08/05/2012 05:10 PM, Giuseppe Penone a écrit : > If you consider important to add the support for them anyway I'll add > them as a third option (image, text label, text png), let me know. >From Lubuntu point of a view, it's a nice support to have. However, I don't think LXDE upstream want it directly in lxpanel trunk, as it match our current theme, and probably only useful with it. That's why an optional way to enable this type of feature will be nice (maybe just enable the third option in the GUI only if a directory custom_flags exist ?) Regards, Julien Lavergne |
From: Giuseppe P. <gi...@gm...> - 2012-08-05 22:22:36
|
I think that introducing a third option only if a particular folder is found is a good idea, this way not only Lubuntu but also an interested user can create a folder in a given place and have a custom theme. I will implement this and let you know when it's done. Cheers, Giuseppe. On Sun, Aug 5, 2012 at 11:47 PM, Julien Lavergne <gi...@ub...> wrote: > Le 08/05/2012 05:10 PM, Giuseppe Penone a écrit : > > If you consider important to add the support for them anyway I'll add > > them as a third option (image, text label, text png), let me know. > From Lubuntu point of a view, it's a nice support to have. > However, I don't think LXDE upstream want it directly in lxpanel trunk, > as it match our current theme, and probably only useful with it. That's > why an optional way to enable this type of feature will be nice (maybe > just enable the third option in the GUI only if a directory custom_flags > exist ?) > > Regards, > Julien Lavergne > |
From: Giuseppe P. <gi...@gm...> - 2012-08-06 21:03:05
|
I issued a new version featuring support for a custom flags theme. the custom theme will be listed only if the custom flags folder is found. furthermore I added the missing flags and made some minor gui changes. Screenshots, source code and debian packages on on http://www.giuspen.com/customs/ Cheers, Giuseppe. On Mon, Aug 6, 2012 at 12:22 AM, Giuseppe Penone <gi...@gm...> wrote: > I think that introducing a third option only if a particular folder is > found is a good > idea, this way not only Lubuntu but also an interested user can create a > folder in a given place > and have a custom theme. > > I will implement this and let you know when it's done. > > Cheers, > Giuseppe. > > > > On Sun, Aug 5, 2012 at 11:47 PM, Julien Lavergne <gi...@ub...> wrote: > >> Le 08/05/2012 05:10 PM, Giuseppe Penone a écrit : >> > If you consider important to add the support for them anyway I'll add >> > them as a third option (image, text label, text png), let me know. >> From Lubuntu point of a view, it's a nice support to have. >> However, I don't think LXDE upstream want it directly in lxpanel trunk, >> as it match our current theme, and probably only useful with it. That's >> why an optional way to enable this type of feature will be nice (maybe >> just enable the third option in the GUI only if a directory custom_flags >> exist ?) >> >> Regards, >> Julien Lavergne >> > > |
From: Giuseppe P. <gi...@gm...> - 2012-08-07 22:01:43
|
I issued one more version where the size of the panel flag/label is configurable. Screenshots, source code and debian packages on http://www.giuspen.com/customs/ Cheers, Giuseppe. On Mon, Aug 6, 2012 at 11:02 PM, Giuseppe Penone <gi...@gm...> wrote: > I issued a new version featuring support for a custom flags theme. > the custom theme will be listed only if the custom flags folder is found. > furthermore I added the missing flags and made some minor gui changes. > Screenshots, source code and debian packages on on > http://www.giuspen.com/customs/ > Cheers, > Giuseppe. > > > > > On Mon, Aug 6, 2012 at 12:22 AM, Giuseppe Penone <gi...@gm...>wrote: > >> I think that introducing a third option only if a particular folder is >> found is a good >> idea, this way not only Lubuntu but also an interested user can create a >> folder in a given place >> and have a custom theme. >> >> I will implement this and let you know when it's done. >> >> Cheers, >> Giuseppe. >> >> >> >> On Sun, Aug 5, 2012 at 11:47 PM, Julien Lavergne <gi...@ub...>wrote: >> >>> Le 08/05/2012 05:10 PM, Giuseppe Penone a écrit : >>> > If you consider important to add the support for them anyway I'll add >>> > them as a third option (image, text label, text png), let me know. >>> From Lubuntu point of a view, it's a nice support to have. >>> However, I don't think LXDE upstream want it directly in lxpanel trunk, >>> as it match our current theme, and probably only useful with it. That's >>> why an optional way to enable this type of feature will be nice (maybe >>> just enable the third option in the GUI only if a directory custom_flags >>> exist ?) >>> >>> Regards, >>> Julien Lavergne >>> >> >> > |