Re: [luabind] My assorted patches against luabind-0.7.1

[Daniel W. <da...@bo...>]

Rodolfo Lima wrote:
> Daniel Wallin escreveu:
> 
>> My point was that it doesn't construct a *const* holder, so it should be:
>>
>>   destructor = crep->destructor();
>>
>> except destructor is already set to that, so you can just remove the line.
> 
> Oh, yes, this makes some sense if crep->destructor() destructs the
> holder, not the object it holds, since object_ptr is the former, not the
> latter. Do you confirm this?

Yes. I've commited your patch with that change to 0.7.1.

> While we're at it, I was checking the above information and found that
> class_base::init(...) declaration in class.hpp line 719 doesn't match
> its implementation signature in class.cpp line 241, although it doesn't
> have any bad consequence (at least for the compiler).

OK, good catch. Patch welcome.

-- 
Daniel Wallin
BoostPro Computing
http://www.boostpro.com