Re: [Ltsp-developer] ldm-trunk fixes

[<va...@fr...>]

On Mon, Feb 11, 2008 at 10:41:01AM -0500, Gideon Romm wrote:
> I have made several changes to the latest ldm-trunk (Revision 803).
> These include:
> 
> 1. Fix to not add "-X" to ssh cmd when in directx mode

not sure on this one...

> 2. Fix to not close out of the X session on failed login of SENTINEL
> (rather simply respawn the greeter)
> 3. Fix to make entry fields not editable when displaying status message
> 4. Fix to eliminate 3-password attempts in favor of one :)

sounds good..

> 5. Added LDM_24HOURCLOCK variable to control the way the time is
> displayed in the greeter

not sure about the name exactly, but i like being able to change the
clock display format.

> 6. Removed confusing datestamp on greeter ( too many questions from
> users)

??

> 7. Modified get_ip() in greeter code to return first UP interface and
> NOT hard-coded eth0
> 8. Display greeter if autologin fails

sounds good.

and one more:
9. set a timeout of 5 seconds when connecting to ldminfod

(which i merged into ldm-trunk)

> The code can be found here:
> 
> http://bazaar.launchpad.net/~gideon/ltsp/gadi-ldm-trunk
> 
> Please review and see if we can merge the changes in or modify them further.

so while i pretty much like most of the proposed changes conceptually...

unfortunately, this is 9 features in one patch which makes it difficult
to review.

additionally, lots of "old code" is commented out, which actually makes
it harder to review the diff, because i see less of the changes, and it
looks more like just additional code.

i did manage to go through and remove most of the commented-out code,
but it's still a little over my head as to what parts of it are ok to
merge.

live well,
  vagrant