Re: [LTP] IFNAME undefined in tcpdump01

[Robert W. <ro...@us...>]

Thanks for the patch, David.  I applied it to our CVS tree.

-Robbie
(Embedded image moved to file: pic13061.jpg)


                                                                           
             "David A. Marlin"                                             
             <dmarlin@redhat.c                                             
             om>                                                        To 
             Sent by:                  ltp-list                            
             ltp-list-admin@li         <ltp...@li...>    
             sts.sourceforge.n                                          cc 
             et                                                            
                                                                   Subject 
                                       [LTP] IFNAME undefined in tcpdump01 
             08/31/2004 11:14                                              
             PM                                                            
                                                                           
                                                                           
                                                                           
                                                                           





I am working with the 20040804 release of LTP.  I noticed that the
tcpdump01 test was failing for me because IFNAME was undefined.  I could
not find where it was supposed to be set in tcpdump01, so I added a line
to set IFNAME if not already defined, modeled after code in 'mc_cmds'.

Attached is a patch showing the code I added.  Note: there are two NICs
in the system I am testing.  I assume that the first (eth0) should be
used as the interface for this test, unless otherwise specified.

Please let me know if IFNAME should be set using some other method, or
if this is an acceptable approach.


Thank you,

d.marlin
--- testcases/network/tcp_cmds/tcpdump/tcpdump01.orig        2004-08-10
22:18:41.000000000 +0000
+++ testcases/network/tcp_cmds/tcpdump/tcpdump01             2004-08-24
22:21:22.000000000 +0000
@@ -39,6 +39,8 @@
 TC=tcpdump
 TCtmp=${TCtmp:-/tmp/$TC$$}
 RHOST=${RHOST:-`hostname`}
+IFNAME=${IFNAME:-$(netstat -i -n | grep "^[b-z]\{2,4\}[0-9][^*]" | \
+      awk '{print $1}' | head -n1)}
 NUMLOOPS=${NUMLOOPS:-20}
 OUTFILE=$TCtmp/tcpdump_out
 LTPROOT=${LTPROOT:-"../../../../"}