RE: [LTP] [Patch] fix problem in chmod06 EACCES should be EPERM

[Robert W. <ro...@us...>]

Changing the expected error code is not acceptable for this test.  However,
I think you are using the wrong environment variable in both cases.  The
TDIRECTORY variable overrides the tst_tmpdir() and tst_rmdir() functions,
which can cause problems.  I think you want to be using the TMPDIR variable
instead.  This variable will tell the tst_tmpdir() and tst_rmdir()
functions to not to use /tmp, but instead use the directory set in TMPDIR.

-Robbie

(Embedded image moved to file: pic22825.jpg)


                                                                           
             "Ling, Xiaofeng"                                              
             <xiaofeng.ling@in                                             
             tel.com>                                                   To 
             Sent by:                  "Ling, Xiaofeng"                    
             ltp-list-admin@li         <xia...@in...>,          
             sts.sourceforge.n         <ltp...@li...>    
             et                                                         cc 
                                                                           
                                                                   Subject 
             08/19/2004 09:45          RE: [LTP] [Patch] fix problem in    
             PM                        chmod06 EACCES should be EPERM      
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           




Is there any comment for the patch, is it acceptable?


>-----Original Message-----
>From: ltp...@li...
>[mailto:ltp...@li...] On Behalf Of
>Ling, Xiaofeng
>Sent: 2004年8月17日 15:58
>To: ltp...@li...
>Subject: [LTP] [Patch] fix problem in chmod06 EACCES should be EPERM
>
>This case is same as the one I report previous. Without TDIRECTORY, it
>can pass.with can't.
>That due to the wrong result checking. see the patch.
>tst_tmpdir create a dir with no other user access , so it returns
>EACCES.
>So there should also a patch to tst_tmpdir or add some code the change
>the mode of the tmpdir.
>
>===================================
>diff -ru chmod06.orig.c chmod06.c
>--- chmod06.orig.c      2004-08-13 10:31:06.149314320 +0800
>+++ chmod06.c   2004-08-13 10:31:14.563035240 +0800
>@@ -118,7 +118,7 @@
>        int exp_errno;
>        int (*setupfunc)();
> } Test_cases[] = {
>-       { TEST_FILE1, "Process is not owner/root", FILE_MODE, EACCES,
>setup1 },
>+       { TEST_FILE1, "Process is not owner/root", FILE_MODE, EPERM,
>setup1 },
>        { TEST_FILE2,  "No Search permissions to process", FILE_MODE,
>EACCES, setup2 },
>        { High_address_node, "Address beyond address space", FILE_MODE,
>EFAULT, no_setup },
>        { (char *)-1, "Negative address", FILE_MODE, EFAULT,
>no_setup },
>
>
>-------------------------------------------------------
>SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
>100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
>Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
>http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285
>_______________________________________________
>Ltp-list mailing list
>Ltp...@li...
>https://lists.sourceforge.net/lists/listinfo/ltp-list
>


-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285
_______________________________________________
Ltp-list mailing list
Ltp...@li...
https://lists.sourceforge.net/lists/listinfo/ltp-list