Re: [LTP] [PATCH] IDcheck.sh didn't check for some groups...

[Dan K. <da...@ke...>]

Robert Williamson wrote:
> I didn't use your patch, but I made the changes to IDcheck.sh and
> rualltests.sh and committed these to the CVS tree.

Unfortunately, the checks in IDcheck.sh are still insufficient.
It does not check for the existence of any groups;
all it does is make sure that various users have groups.

Thus the following tests will fail or crash on a system
that has all the right users, but lacks certain groups:

setregid/setregid02.c:  root = *(getgrnam("root"));
setregid/setregid02.c:  users = *( getgrnam("users"));
setregid/setregid02.c:  bin = *(getgrnam("bin"));
setregid/setregid03.c:  root = *(getgrnam("root"));
setregid/setregid03.c:  users = *( getgrnam("users"));
setregid/setregid03.c:  sys = *(getgrnam("sys"));
setregid/setregid03.c:  bin = *(getgrnam("bin"));
setregid/setregid04.c:  root = *(getgrnam("root"));
setregid/setregid04.c:  users = *( getgrnam("users"));
setregid/setregid04.c:  daemongr = *(getgrnam("daemon"));
setregid/setregid04.c:  bin = *(getgrnam("bin"))

chmod/change_owner.c:   if ((ltpgroup = getgrnam("nobody")) == NULL) {
chmod/change_owner.c:           if ((ltpgroup = getgrnam("nogroup")) == NULL) {
chmod/chmod07.c:        if ((ltpgroup = getgrnam(LTPGRP)) == NULL) {
chown/change_owner.c:   if ((ltpgroup = getgrnam("nobody")) == NULL) {
chown/change_owner.c:           if ((ltpgroup = getgrnam("nogroup")) == NULL) {
creat/creat08.c:                if ((group = getgrnam("nobody")) == NULL) {
creat/creat08.c:                if ((group = getgrnam("bin")) == NULL) {
fchmod/change_owner.c:  if ((ltpgroup = getgrnam("nobody")) == NULL) {
fchmod/change_owner.c:          if ((ltpgroup = getgrnam("nogroup")) == NULL) {
fchmod/fchmod02.c:      if ((ltpgroup = getgrnam(LTPGRP)) == NULL) {
fchown/change_owner.c:  if ((ltpgroup = getgrnam("nobody")) == NULL) {
fchown/change_owner.c:          if ((ltpgroup = getgrnam("nogroup")) == NULL) {
lchown/create_link.c:   if ((ltpgroup = getgrnam(LTPGRP)) == NULL) {
open/open10.c:          if ((group = getgrnam("nobody")) == NULL) {
open/open10.c:          if ((group = getgrnam("bin")) == NULL) {
- Dan

-- 
Dan Kegel
http://www.kegel.com
http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045