Re: [LTP] fchown03 test

[Robert W. <ro...@us...>]

FYI. Patch applied to CVS and will be included in the July release.

- Robbie

Robert V. Williamson <ro...@us...>
Linux Test Project
IBM Linux Technology Center
Phone: (512) 838-9295   T/L: 638-9295
http://ltp.sourceforge.net


                                                                                                                             
                      Robert                                                                                                 
                      Williamson/Austin/IBM@IBM        To:       Kent Yoder <ke...@au...>                             
                      US                               cc:       ltp...@li..., William Jay                 
                      Sent by:                          Huie/Poughkeepsie/IBM@IBMUS                                          
                      ltp...@li...ur        Subject:  Re: [LTP] fchown03 test                                     
                      ceforge.net                                                                                            
                                                                                                                             
                                                                                                                             
                      06/24/2002 12:18 PM                                                                                    
                                                                                                                             
                                                                                                                             




Ohh....ok.  I'll check-in your changes sometime this week. Thanks, for the
clarification.

- Robbie

Robert V. Williamson <ro...@us...>
Linux Test Project
IBM Linux Technology Center
Phone: (512) 838-9295   T/L: 638-9295
http://ltp.sourceforge.net



                      Kent Yoder

                      <key@austin.ibm.c        To:       Robert
Williamson/Austin/IBM@IBMUS
                      om>                      cc:       William Jay
Huie/Poughkeepsie/IBM@IBMUS,

<ltp...@li...>
                      06/24/2002 11:13         Subject:  Re: [LTP] fchown03
test
                      AM







  Nope, that didn't do it..  Basically the test calls fchown in a situation
where fchown should clear the setuid and setguid bits on a file, and if it
doesn't, prints an error (which is right), but then shows that the expected
file permissions have those bits on instead of off...

Kent

Thus Spake Robert Williamson:

>
>I acutally fixed this...I think...but had to wait forever to check in the
>change b/c CVS was down. Try this patched version...
>
>(See attached file: fchown03.c)
>
>- Robbie
>
>Robert V. Williamson <ro...@us...>
>Linux Test Project
>IBM Linux Technology Center
>Phone: (512) 838-9295   T/L: 638-9295
>http://ltp.sourceforge.net
>
>
>

>                      William Jay

>                      Huie/Poughkeepsie/IBM@IBM        To:       Kent
Yoder <ke...@au...>
>                      US                               cc:
ltp...@li...
>                      Sent by:                         Subject:  Re: [LTP]
fchown03 test
>                      ltp...@li...ur

>                      ceforge.net

>

>

>                      06/21/2002 04:32 PM

>

>

>
>
>
>
>        Your patch would definately clean up the error message. I would
>reccommend checking the CVS code if you're not using it. There were some
>problems in chown05 where when run w/o the -f flag it was doing improper
>checking. I think Robbie may have made some changes to the others.
>        Previously they were run w/ a -f flag to skip functionality (since
>removed from the list) so we now have to work on changing any erronous
>errors.
>        Happy Friday,
>        j
>
>
>Jay Huie
> wj...@us...
> zSeries Linux System Test
> Phone: 845-435-8164
>
>
>
>Sent by:        ltp...@li...
>
>
>To:        ltp...@li...
>cc:
>Subject:        [LTP] fchown03 test
>
>
>
>
>Hi,
>
>In running the ltp on the scalable build 2, the fchown03 test failed,
>giving the following message:
>
>fchown03 1 FAIL : testfile: Incorrect mode permissions 0106770, Expected
>0106770
>
>
>so the expected result was supposedly the same as what we looked for, but
>the test failed.  Hopefully the following patch fixes the problem.
>
>Please cc me on any replies, as I am not subscribed.
>
>Thanks,
>Kent
>
>--- fchown03.c  Fri Jun 21 09:04:37 2002
>+++ fchown03.new.c      Fri Jun 21 09:09:17 2002
>@@ -85,6 +85,7 @@
>
>#define FILE_MODE      S_IFREG | S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH
>#define NEW_PERMS       S_IFREG | S_IRWXU | S_IRWXG | S_ISUID | S_ISGID
>+#define FCHOWN_PERMS    S_IFREG | S_IRWXU | S_IRWXG
>#define TESTFILE       "testfile"
>
>int fildes;                    /* File descriptor for test file */
>@@ -173,7 +174,7 @@
>if (stat_buf.st_mode & (S_ISUID | S_ISGID)) {
>tst_resm(TFAIL, "%s: Incorrect mode permissions"
>" %#o, Expected %#o", TESTFILE,
>-                                        stat_buf.st_mode, NEW_PERMS);
>+                                        stat_buf.st_mode, FCHOWN_PERMS);
>} else {
>tst_resm(TPASS, "fchown() on %s succeeds: "
>"Setuid/gid bits cleared",
>TESTFILE);
>
>
>
>
>-------------------------------------------------------
>Sponsored by:
>ThinkGeek at http://www.ThinkGeek.com/
>_______________________________________________
>Ltp-list mailing list
>Ltp...@li...
>https://lists.sourceforge.net/lists/listinfo/ltp-list
>
>
>
>








-------------------------------------------------------
Sponsored by:
ThinkGeek at http://www.ThinkGeek.com/
_______________________________________________
Ltp-list mailing list
Ltp...@li...
https://lists.sourceforge.net/lists/listinfo/ltp-list