Re: [LTP] [PATCH] ext4-new-features: modify ext4-delalloc-mballoc can not find ffsb-config file

[Zorro L. <zl...@re...>]

在 2014年09月29日 23:14, ch...@su... 写道:
> Hi!
>> diff --git a/testcases/kernel/fs/ext4-new-features/ext4-delalloc-mballoc/ext4-alloc-test.sh b/testcases/kernel/fs/ext4-new-features/ext4-delalloc-mballoc/ext4-alloc-test.sh
>> index 1ffba13..47d9174 100755
>> --- a/testcases/kernel/fs/ext4-new-features/ext4-delalloc-mballoc/ext4-alloc-test.sh
>> +++ b/testcases/kernel/fs/ext4-new-features/ext4-delalloc-mballoc/ext4-alloc-test.sh
>> @@ -40,7 +40,7 @@ ext4_test_remount()
>>   		return
>>   	fi
>>   
>> -	ffsb ffsb-config0 > /dev/null
>> +	ffsb $LTPROOT/testcases/bin/ffsb-config0 > /dev/null
>>   	if [ $? -ne 0 ]; then
>>   		tst_resm TFAIL "ffsb returned failure"
>>   		umount mnt_point
>> @@ -92,7 +92,7 @@ ext4_test_delalloc_mballoc()
>>   		return
>>   	fi
>>   
>> -	ffsb ffsb-config$2 > /dev/null
>> +	ffsb $LTPROOT/testcases/bin/ffsb-config$2 > /dev/null
> These should idealy be treated as a datafiles.
>
> So the ext4-ffsb-config/Makefile should have:
>
> INSTALL_DIR := testcases/data/ext4-ffsb/
>
> then the files would be installed under this path and the
> path to the files in the shell script above should then be
> $LTPROOT/testcases/data/ext4-ffsb/ffsb-config0
>
> Can you please update the patch?
>
Thanks for you suggestion, I think that's better. I have updated the 
patch and resent it, please check.

Thank you,
Zorro Lang