Re: [LTP] [PATCH] timerfd_settime01: initialise itimerspec new_value

[Jan S. <jst...@re...>]

----- Original Message -----
> From: ch...@su...
> To: "Jan Stancek" <jst...@re...>
> Cc: ltp...@li...
> Sent: Wednesday, 20 August, 2014 4:04:16 PM
> Subject: Re: [LTP] [PATCH] timerfd_settime01: initialise itimerspec new_value
> 
> Hi!
> > Before kernel validates that fd is valid, it checks itimerspec struct
> > with timespec_valid(). This struct is currently not initialised in test,
> > which can cause failures, for example:
> > 
> > timerfd_settime01    1  TFAIL  :  timerfd_settime01.c:121:
> > timerfd_settime()
> >                         failed unexpectedly; expected: 9 - Bad file
> >                         descriptor: TEST_ERRNO=EINVAL(22): Invalid argument
> > timerfd_settime01    2  TFAIL  :  timerfd_settime01.c:121:
> > timerfd_settime()
> >                         failed unexpectedly; expected: 14 - Bad address:
> >                         TEST_ERRNO=EINVAL(22): Invalid argument
> > 
> > Fix this by giving fields in this struct some deterministic values
> > (zero in this patch).
> 
> I've reproduced the failure and tested the fix.
> 
> Tested and acked.

Pushed.

Regards,
Jan

> 
> --
> Cyril Hrubis
> ch...@su...
>