Re: [LTP] [PATCH] pipeio/pipeio.c: cleanup

[<ch...@su...>]

Hi!
> This patch is a long cleanup, thanks for reviewing this.
> >
> > * The C option is removed
> >   (this one makes sense because it's not supported)
> Yes.
> >
> > * The B background option is removed
> 
> Here I think the "-B" option does not make much sense.
> And if "-B" option is specified, the parent process will always
> return 0, which won't reflect the correct test results.
> >
> > * The d dir option no longer copies the dir name, why?
> "-d" option is used to specify a directory, where named pipe is created, other
> than the current directory. Tst_tmpdir() will create a temporary directory, so I think
> "-d" option may be removed.

This is exactly what should be in the commit message. Because if you
don't write the motivation for the changes there, I need to figure it
out myself, which takes much more time.

-- 
Cyril Hrubis
ch...@su...