Re: [LTP] [PATCH V2 8/8] controllers/cpuset: reorganization

[<ch...@su...>]

Hi!
> A separate name (from controller_cpuset01 to controller_cpuset11) is
> assigned to each cpuset shell testcase (which was invoked earlier
> by run_cpuset_test.sh).
> 
> This will simplify results analysis.
> 
> Signed-off-by: Stanislav Kholmanskikh <sta...@or...>
> ---
>  runtest/controllers                                |   13 ++
>  .../cpuset_base_ops_testset.sh                     |    8 +-
>  .../cpuset_exclusive_test/cpuset_exclusive_test.sh |    8 +-
>  .../kernel/controllers/cpuset/cpuset_funcs.sh      |   23 ++-
>  .../cpuset_hierarchy_test/cpuset_hierarchy_test.sh |    8 +-
>  .../cpuset_hotplug_test/cpuset_hotplug_test.sh     |    6 +-
>  .../cpuset_inherit_test/cpuset_inherit_testset.sh  |    8 +-
>  .../cpuset_load_balance_test.sh                    |    8 +-
>  .../cpuset_sched_domains_test.sh                   |    8 +-
>  .../cpuset_memory_pressure_testset.sh              |    8 +-
>  .../cpuset_memory_spread_testset.sh                |    8 +-
>  .../cpuset_memory_test/cpuset_memory_testset.sh    |    8 +-
>  .../cpuset_syscall_test/cpuset_syscall_testset.sh  |    8 +-
>  .../kernel/controllers/cpuset/run_cpuset_test.sh   |  183 --------------------
>  testcases/kernel/controllers/test_controllers.sh   |   20 --
>  15 files changed, 75 insertions(+), 250 deletions(-)
>  delete mode 100755 testcases/kernel/controllers/cpuset/run_cpuset_test.sh
> 
> diff --git a/runtest/controllers b/runtest/controllers
> index 94fc185..a737b2f 100644
> --- a/runtest/controllers
> +++ b/runtest/controllers
> @@ -12,4 +12,17 @@ memcg_stress		memcg_stress_test.sh
>  memcg_control		PAGESIZE=$(mem_process -p);memcg_control_test.sh $PAGESIZE $PAGESIZE $((PAGESIZE * 2))
>  cgroup_fj	run_cgroup_test_fj.sh
>  controllers	test_controllers.sh
> +
> +controller_cpuset01	cpuset_base_ops_testset.sh
> +controller_cpuset02	cpuset_inherit_testset.sh
> +controller_cpuset03	cpuset_exclusive_test.sh
> +controller_cpuset04	cpuset_hierarchy_test.sh
> +controller_cpuset05	cpuset_syscall_testset.sh
> +controller_cpuset06	cpuset_sched_domains_test.sh
> +controller_cpuset07	cpuset_load_balance_test.sh
> +controller_cpuset08	cpuset_hotplug_test.sh
> +controller_cpuset09	cpuset_memory_testset.sh
> +controller_cpuset10	cpuset_memory_pressure_testset.sh
> +controller_cpuset11	cpuset_memory_spread_testset.sh

Looking at this part made me think if it would  be better to name the
testcases accordingly to the the shell script names, rather than just
numbering them. What do you think?

The rest of the patchset is pushed.

-- 
Cyril Hrubis
ch...@su...